Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Add support for all Samsung Mbed targets #13977

Merged
merged 5 commits into from
Dec 11, 2020
Merged

CMake: Add support for all Samsung Mbed targets #13977

merged 5 commits into from
Dec 11, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

CMake: Add support for all Samsung Mbed targets

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 27, 2020
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/team-samsung @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team November 27, 2020 18:30
@mergify
Copy link

mergify bot commented Dec 1, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

0xc0170
0xc0170 previously approved these changes Dec 2, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Dec 3, 2020
@mbed-ci
Copy link

mbed-ci commented Dec 3, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Dec 3, 2020
@mergify
Copy link

mergify bot commented Dec 7, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2020

I'll rebase once another CMake target support gets in

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

Rebasing and starting CI

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

CI started

@mergify mergify bot dismissed 0xc0170’s stale review December 10, 2020 09:44

Pull request has been modified.

@mbed-ci
Copy link

mbed-ci commented Dec 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot added the needs: work label Dec 10, 2020
@mergify
Copy link

mergify bot commented Dec 10, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: CI label Dec 10, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

Resolving conflict now

@0xc0170 0xc0170 mentioned this pull request Dec 10, 2020
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

This PR goes in via #14024

0xc0170
0xc0170 reviewed Dec 10, 2020
View reviewed changes
targets/TARGET_Samsung/TARGET_SIDK_S5JS100/CMakeLists.txt

target_sources(mbed-core
INTERFACE
# TODO CMAKE: The files commented below trigger a dependency on other libraries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed this one. I created #14025 to track this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pan- is aware of this and has raised the issue with @ARMmbed/team-samsung.

@0xc0170 0xc0170 merged commit a1ec4ed into ARMmbed:master Dec 11, 2020
@hugueskamba hugueskamba deleted the hk_cmake_add_samsung branch December 11, 2020 09:52
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@heuisam heuisam heuisam approved these changes

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

@jh6186 jh6186 Awaiting requested review from jh6186

Assignees
No one assigned
Labels
needs: work release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @heuisam @mbedmain