Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maxim: Remove support for some Maxim targets #13969

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Maxim: Remove support for some Maxim targets #13969

merged 3 commits into from
Dec 10, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Nov 26, 2020 •
edited
Loading

Summary of changes

The following Mbed targets are no longer supported by Maxim:

  • MAX32600MBED
  • MAX32620HSP
  • MAX32610 family

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
MAX32600MBED: Remove support
ff5fca6 
The target is no longer supported by Maxim
@hugueskamba
MAX32620HSP: Remove source files
4a0718c 
This target was not supported by Mbed OS 6
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 26, 2020
@ciarmcom ciarmcom requested a review from a team November 26, 2020 13:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/team-maximintegrated @ARMmbed/mbed-os-maintainers please review.

@hugueskamba
MAX32610: Remove source files
6ccee16 
The targets of this family are not supported by Mbed OS 6
@hugueskamba hugueskamba changed the title Maxim: Remove support for MAX32600MBED and MAX32620HSP Maxim: Remove support for some Maxim targets Nov 26, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Nov 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 30, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Nov 30, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2020

CI restarted

@mergify mergify bot added needs: work and removed needs: CI labels Nov 30, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 30, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ❌
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

khariya
khariya approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@khariya khariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugueskamba, Thanks for submitting this PR!

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

dynamic memory not used anymore, I'll merge this

@0xc0170 0xc0170 merged commit bd3f13c into ARMmbed:master Dec 10, 2020
@mergify mergify bot removed the ready for merge label Dec 10, 2020
@hugueskamba hugueskamba deleted the hk_remove_MAXIM_support branch December 11, 2020 09:53
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khariya khariya khariya approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

Assignees
No one assigned
Labels
release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @khariya @mbedmain