Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nanostack dependency lib #13953

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Nov 23, 2020

Summary of changes

  • Added netsocket library to nanostack CMake with target_link_libraries as nanostack has dependency

Impact of changes

None.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Manual testing:
Successfully build mesh-minimal example by only including nanostack in CMakeLists.txt of target_link_libraries which intern brought netsocket library


Reviewers

@0xc0170 @hugueskamba


- Added netsocket libraries to nanostack CMake with target_link_libraries as nanostack has dependency
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 23, 2020
@ciarmcom ciarmcom requested review from 0xc0170, hugueskamba and a team November 23, 2020 20:30
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@hugueskamba @0xc0170 @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this found (where this dependency come from) ? I thought nanostack is own library hat does not require mbed libraries?

@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 24, 2020

How was this found (where this dependency come from) ? I thought nanostack is own lbiraryt hat does not require mbed libraries?

@0xc0170 I found this issue when I add the CMake support for mesh-minimal example as these examples dependent on nanostack and nanostack intern uses the headers like MeshInterface.h which is part of the netscoket library

@mergify mergify bot added needs: CI and removed needs: review labels Nov 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 24, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit b7c2b77 into ARMmbed:master Nov 25, 2020
@mergify mergify bot removed the ready for merge label Nov 25, 2020
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants