-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nanostack dependency lib #13953
Add nanostack dependency lib #13953
Conversation
- Added netsocket libraries to nanostack CMake with target_link_libraries as nanostack has dependency
@rajkan01, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this found (where this dependency come from) ? I thought nanostack is own library hat does not require mbed libraries?
@0xc0170 I found this issue when I add the CMake support for mesh-minimal example as these examples dependent on nanostack and |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
netsocket
library tonanostack
CMake withtarget_link_libraries
as nanostack has dependencyImpact of changes
None.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Manual testing:
Successfully build mesh-minimal example by only including nanostack in CMakeLists.txt of target_link_libraries which intern brought netsocket library
Reviewers
@0xc0170 @hugueskamba