You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile definitions (macros) should be passed to both GCC_ARM and ARM toolchains:
For GCC_ARM, the linker script is preprocessed, which is already the case
For the ARM toolchain, we can pass --predefine=@<definition_file>.txt directly to armlink. This PR adds such support.
This is necessary, if an application needs to start with an offset (MBED_APP_START), e.g. to be loaded by a bootloader.
Impact of changes
Macros are now passed to the Arm Compiler linker.
Migration actions required
None.
Documentation
None.
Pull request type
[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)
Test results
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
I knew GCC Arm did not pass it by default but I don't recall why I was under impression ARMClang is passing them to linker by default 🙄 If that is the case, making the symbols already done for gcc also to other toolchain +1.
No matter what compiler we use, the build system needs to macros in some way. And CMake doesn't pass macros (compile definitions) at linking stage by default, so we need to do it.
The difference between arm-none-eabi-ld and armlink is the former doesn't support macros (thus requires preprocessing) and the latter does support that.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDong-Arm
changed the title
ciarmcom
added
the
release-type: patch
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Summary of changes
Compile definitions (macros) should be passed to both GCC_ARM and ARM toolchains:
--predefine=@<definition_file>.txtdirectly toarmlink. This PR adds such support.This is necessary, if an application needs to start with an offset (
MBED_APP_START), e.g. to be loaded by a bootloader.Impact of changes
Macros are now passed to the Arm Compiler linker.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers
@0xc0170 @hugueskamba @rajkan01