Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CAN function to GR-MANGO #13898

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Adding CAN function to GR-MANGO #13898

merged 3 commits into from
Dec 7, 2020

Conversation

RyoheiHagimoto
Copy link
Contributor

@RyoheiHagimoto RyoheiHagimoto commented Nov 11, 2020 •
edited by 0xc0170
Loading

Summary of changes

Adding CAN function to GR-MANGO board.
Updated I/O register definition files

Impact of changes

Updated RZ/A2M I/O register definition files.
This is not affect to Mbed APIs.

Migration actions required

Documentation

Added CAN APIs to GR-MANGO board.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

The result of Greentea is follows.
greentea_grmango_20201111.zip

Reviewers

@ciarmcom ciarmcom requested review from a team November 11, 2020 06:30
@ciarmcom
Copy link
Member

@RyoheiHagimoto, thank you for your changes.
@ARMmbed/team-renesas-rz @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Nov 12, 2020
View reviewed changes
targets/TARGET_RENESAS/TARGET_RZ_A2XX/r_can/src/r_can_rz.c
@@ -0,0 +1,2758 @@
/***********************************************************************************************************************
* DISCLAIMER
* This software is supplied by Renesas Electronics Corporation and is only intended for use with Renesas products. No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What license is this, is this permissive? I recall seeing this in older files and our license scanning returned warnings about these files.
Would it be possible to use permissive license for these new files (there will be a new ticket to fix already merged files).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our license check in Travis reporteed only missing SPDX

File: r_can_rz_config.h reason: Missing SPDX license identifier
File: r_can_rz_if.h reason: Missing SPDX license identifier
File: r_can_rz.c reason: Missing SPDX license identifier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I added Apache-2.0 license to the pointed files.

@mergify mergify bot added needs: CI and removed needs: review labels Nov 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 17, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Nov 18, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 18, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️

@RyoheiHagimoto
Copy link
Contributor Author

RyoheiHagimoto commented Nov 18, 2020 •
edited
Loading

I cannot see Details of unsuccessful-CI could you let me know how to see the log of the build, or how to create the same project on my PC?

@RyoheiHagimoto
Copy link
Contributor Author

I cannot find FAIL folder in Logs and Artifacts.
I can find only PASS folder.
Could you let me know what was failed?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2020

I restarted CI to get the latest results. If they fail, lets review together and find why is it failing.

@mbed-ci
Copy link

mbed-ci commented Dec 1, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ❌
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ❌
jenkins-ci/mbed-os-ci_greentea-test ❌

@RyoheiHagimoto
Copy link
Contributor Author

RyoheiHagimoto commented Dec 1, 2020 •
edited
Loading

@0xc0170 -san

Could you let me know how to check the result of jenkins-ci/mbed-os-ci_dynamic-memory-usage?
I could find the other errors but the errors ware occurred in the part I did not change them at all. I changed only RZ_A2XX part of targets/targets.json and subfolders in targets/TARGET_RENESAS.
Could you let me know what should I do next?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 2, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 2, 2020

@RyoheiHagimoto Internal CI error, I restarted tests , they should pass now

@mbed-ci
Copy link

mbed-ci commented Dec 2, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Dec 2, 2020
@RyoheiHagimoto
Copy link
Contributor Author

@0xc0170 -san,
Could you retry CI test?
GreenTea-test failed for NUCLEO_F767ZI.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Dec 3, 2020
@RyoheiHagimoto
Copy link
Contributor Author

@0xc0170 -san,
Could you restart CI?
GreenTea-test failed for NUCLEO_F767ZI.
This is the same result of build 3.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2020

Yes, unfortunately again networking error. I'll start restarting all jobs once I get confirmation this is fixed in CI.

@mbed-ci
Copy link

mbed-ci commented Dec 7, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 7, 2020

dynamic-memory-usage can be ignored as it is not valid anymore. I'll merge this now

@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release-type: feature labels Dec 7, 2020
@0xc0170 0xc0170 merged commit 0fa43ca into ARMmbed:master Dec 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 7, 2020

I set this to patch (target update)

@mergify mergify bot removed the ready for merge label Dec 7, 2020
@RyoheiHagimoto RyoheiHagimoto deleted the add_can_to_grmango branch December 10, 2020 01:14
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RyoheiHagimoto @ciarmcom @0xc0170 @mbed-ci @mbedmain