-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Fix error that prevented re-build #13895
Merged
0xc0170
merged 1 commit into
ARMmbed:master
from
hugueskamba:hk_cmake_fix_subsequent_runs
Nov 12, 2020
Merged
CMake: Fix error that prevented re-build #13895
0xc0170
merged 1 commit into
ARMmbed:master
from
hugueskamba:hk_cmake_fix_subsequent_runs
Nov 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
reviewed
Nov 10, 2020
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Nov 10, 2020
@hugueskamba, thank you for your changes. |
Promote MBED_TOOLCHAIN_FILE_USED to cache variable so its previous state can be recalled when re-building. This is because CMAKE_TOOLCHAIN_FILE is also a cache variable and its value is set on first run when it has not been set.
hugueskamba
force-pushed
the
hk_cmake_fix_subsequent_runs
branch
from
November 10, 2020 19:55
3525f74
to
a70edcd
Compare
0xc0170
approved these changes
Nov 11, 2020
rajkan01
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Promote
MBED_TOOLCHAIN_FILE_USED
to cache variable soits previous state can be recalled when re-building. This
is because
CMAKE_TOOLCHAIN_FILE
is also a cache variable and itsvalue is set on first run when it has not been set.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers