Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license notice to Arm copyrighted source files plus SDPX to already licensed files #13724

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Add license notice to Arm copyrighted source files plus SDPX to already licensed files #13724

merged 2 commits into from
Oct 16, 2020

Conversation

harmut01
Copy link
Contributor

@harmut01 harmut01 commented Oct 6, 2020

Summary of changes

Apache-2.0 license notice added to source files missing a license header.

Impact of changes

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba @ARMmbed/mbed-os-maintainers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 6, 2020
@ciarmcom
Copy link
Member

ciarmcom commented Oct 6, 2020

@harmut01, thank you for your changes.
@toyowata @maclobdell @hugueskamba @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

LDong-Arm
LDong-Arm reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harmut01, I've added comment regarding the license header format. You changes are probably okay to merge I guess, let's see what the maintainers say. (Of course, no need to clean up existing notices in other files)

connectivity/libraries/nanostack-libservice/test/libService/unittest/nsnvmhelper/main.cpp Outdated Show resolved Hide resolved
connectivity/libraries/nanostack-libservice/test/libService/unittest/nsnvmhelper/main.cpp Show resolved Hide resolved
@harmut01 harmut01 force-pushed the license_refactor branch 6 times, most recently from 2e4d864 to 733bc3a Compare October 8, 2020 15:20
0xc0170
0xc0170 reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, lets remove the first line with old name. The rest looks fine to me.

Thanks @harmut01 !

@harrisonmutai-arm
Add license notice to Arm copyrighted source files
d1d6bf5 
Scancode found missing license notices in our source files. This commit
addresses those issues by adding an Apache-2.0 notice to source files
highlighted.
@harrisonmutai-arm
Add SPDX license identifier to Arm files
4fad111 
Add license identifier to files which Arm owns the copyright to,
and contain either BSD-3 or Apache-2.0 licenses. This is to address
license errors raised by scancode analysis.
@mergify mergify bot added needs: CI and removed needs: review labels Oct 15, 2020
@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot removed the needs: CI label Oct 15, 2020
@0xc0170 0xc0170 merged commit 61aa681 into ARMmbed:master Oct 16, 2020
@mergify mergify bot removed the ready for merge label Oct 16, 2020
@0xc0170 0xc0170 changed the title Add license notice to Arm copyrighted source files Add license notice to Arm copyrighted source files plus SDPX to already licensed files Oct 16, 2020
@harmut01 harmut01 deleted the license_refactor branch October 16, 2020 09:40
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDong-Arm LDong-Arm LDong-Arm left review comments

@toyowata toyowata toyowata approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba Awaiting requested review from hugueskamba

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@harmut01 @ciarmcom @mbed-ci @0xc0170 @toyowata @LDong-Arm @mbedmain @harrisonmutai-arm