Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ble: reset transport last and reset the default chars in gatt server #13704

Merged
merged 1 commit into from
Oct 13, 2020
Merged

ble: reset transport last and reset the default chars in gatt server #13704

merged 1 commit into from
Oct 13, 2020

Conversation

paul-szczepanek-arm
Copy link
Member

Summary of changes

Gatt server is not being reset correctly, this fixes it. Fixes: #13503

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 2, 2020
@ciarmcom ciarmcom requested review from pan- and a team October 2, 2020 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 2, 2020

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

pan-
pan- approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: review labels Oct 5, 2020
@paul-szczepanek-arm paul-szczepanek-arm mentioned this pull request Oct 9, 2020
Closed
@adbridge
Copy link
Contributor

Ci started

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 changed the title reset transport last and reset the default chars in gatt server ble: reset transport last and reset the default chars in gatt server Oct 13, 2020
@0xc0170 0xc0170 merged commit 83579b1 into ARMmbed:master Oct 13, 2020
@mergify mergify bot removed the ready for merge label Oct 13, 2020
@DBS06 DBS06 mentioned this pull request Oct 14, 2020
Open
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@pan- pan- pan- approved these changes

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
7 participants
@paul-szczepanek-arm @ciarmcom @adbridge @mbed-ci @pan- @0xc0170 @mbedmain