Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32WB update drivers version to CUBE V1.8.0 #13659

Merged
merged 2 commits into from
Oct 19, 2020
Merged

STM32WB update drivers version to CUBE V1.8.0 #13659

merged 2 commits into from
Oct 19, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

ST Cube drivers version is updated from V1.7.0 to V1.8.0
which is the latest official version from:

https://github.com/STMicroelectronics/STM32CubeWB/

@ARMmbed/team-st-mcd

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Verified with ST CI

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 23, 2020
@ciarmcom ciarmcom requested a review from a team September 23, 2020 16:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

@jeromecoutant Please rebase this one as well, will start CI

@jeromecoutant
Copy link
Collaborator Author

@0xc0170 Done :-)

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI started

0xc0170
0xc0170 previously approved these changes Oct 15, 2020
View reviewed changes
connectivity/drivers/ble/FEATURE_BLE/TARGET_STM32WB/STM32Cube_FW/ble_bufsize.h
*****************************************************************************
* @attention
*
* <h2><center>&copy; Copyright (c) 2019 STMicroelectronics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall seeing other cube drivers using SPDX, not this version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, this is because file comes from CubeFW without any modification....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add SPDX identifiers and send also upstream?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, file comes from https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Middlewares/ST/STM32_WPAN/ble/core/ble_bufsize.h
Like in https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_STM/TARGET_STM32WB/STM32Cube_FW
I prefer to avoid any modification to ease driver updates when there is a new ST package

Copy link
Contributor

@0xc0170 0xc0170 Oct 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis fails as SPDX is required for all new files :(

the only way to address this would be to add the driver to license check ignore.

  1. add to ignore for now,
  2. add SPDX to the usptream repo (link above)
  3. update drivers in this tree once the update is due

what do you think?

Copy link
Collaborator Author

@jeromecoutant jeromecoutant Oct 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should ignore all files */STM32Cube_FW/*
in targets/TARGET_STM
and in other directories like this one....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please add them to codecheckignore list. This will make Travis green.

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 16, 2020

waiting for #13745

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 16, 2020

I restarted travis but it will fail as no change to the PR itself. @jeromecoutant can you rebase? master got updated with 13745. I can actually test this, I'll create new testing PR with this one and the latest master

@jeromecoutant
Copy link
Collaborator Author

can you rebase?

done

@mergify mergify bot dismissed 0xc0170’s stale review October 16, 2020 15:29

Pull request has been modified.

@mergify mergify bot added needs: work and removed needs: CI labels Oct 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

I did not realize codeignore check is for styling not for license. Any file in our repo must follow the license guide. Introducing a ignore file for licensing is not an answer, it is dangerous to do.
I do not think we have any other way only to wait for the driver update (it was always the case), sorry for earlier confusion. I realized this after checking the updated code changes.

How long would it take to update the driver and bring the update here? Adding SPDX should be simple to do for this driver as there are not that many files.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020 •
edited
Loading

Extend my above comment - the 3rd party driver has a permissive license, missing SPDX identifier - ignoring completely the check is not the answer, we need to fix the check.

It should not yet block the PRs, we will need to clean this up step by step.

I am looking at the license check and how to fix it.

@mergify
Copy link

mergify bot commented Oct 19, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170 0xc0170 self-requested a review October 19, 2020 12:30
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

@jeromecoutant PR #13782 merged, and also another one causing a conflict. Please rebase. Travis should be green now

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

@jeromecoutant 8b945f1 - can you cherry pick this commit here ?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

License check failed, please review license issues found in modified files

Thanks that was quick ! I fixed only new files, I updated to fix also updated files. 0xc0170@6ba2859

@0xc0170 @jeromecoutant
travis: ignore spdx reports
5eeced1 
Do not force red status for PRs due to SPDX missing (license must be there). We will
add better SPDX checks later (more work required to enable these for 3rd party code).
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

license check passed, I'll merge this one once CI completes, the rest depending on the fix can be rebased then.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

Sorry for the trouble, the rest of the PRs shall progress after merging this one.

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 8d9dabe into ARMmbed:master Oct 19, 2020
@mergify mergify bot removed the ready for merge label Oct 19, 2020
@jeromecoutant jeromecoutant deleted the PR_WB_1_8 branch October 19, 2020 15:40
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @mbedmain