Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use impl namespace in GattServer att_cb registration, not ble #13653

Merged
merged 1 commit into from Sep 23, 2020
Merged

Use impl namespace in GattServer att_cb registration, not ble #13653

merged 1 commit into from Sep 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2020

Summary of changes

Fix compilation of apps when BLE is enabled.

If this is the correct fix, then this shouldn't have passed CI, should
it?


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

If this is the correct fix, then this shouldn't have passed CI, should
it?
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 21, 2020
@ciarmcom
Copy link
Member

@jrobeson, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team September 21, 2020 22:30
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrobeson The fix is correct. It highlight we should but more BLE configurations in the CI. Compiling without GattClient is fairly common.

@mergify mergify bot added needs: CI and removed needs: review labels Sep 22, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 23, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit d896ea3 into ARMmbed:master Sep 23, 2020
@mergify mergify bot removed the ready for merge label Sep 23, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants