-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M2351: Support GCC and IAR #13643
Merged
0xc0170
merged 7 commits into
ARMmbed:mbed-os-5.15
from
OpenNuvoton:nuvoton_m2351_gcc_iar_5.15
Oct 13, 2020
Merged
M2351: Support GCC and IAR #13643
0xc0170
merged 7 commits into
ARMmbed:mbed-os-5.15
from
OpenNuvoton:nuvoton_m2351_gcc_iar_5.15
Oct 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ths is to prepare for supporting GCC/IAR officially.
1. Re-organize to make clear all targets/toolchains support in single startup file 2. Inline assembly syntax is limited, esp. on IAR. Try paving the way for accessing external symbols still in inline assembly instead of re-write in assembly. 3. Update GCC C run-time sequence to fit future GCC script file.
1. Refine memory partition files to support different toolchains 2. Exclude NSC region from flash IAP range
Separate out secure/non-secure ARMC6 scatter files instead of merging them
1. Enable GCC support on non-secure targets 2. Disable GCC support on secure targets becasue of GCC bug (as of 9-2019-q4-major): In non-secure entry function, callee-saved registers must be restored, but they are incorrectly cleared at optimization level "Os".
1. Enable IAR on non-secure targets 2. Disable IAR on secure targets because: (1) IAR toolchain bug: As of IAR 8.32, cmse_nonsecure_caller() is not always inlined. (2) TFM hasn't supported IAR yet.
@ccli8, thank you for your changes. |
0xc0170
approved these changes
Sep 29, 2020
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
andypowers
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR is backport of #12353 and #12366 to
mbed-os-5.15
branch. It has the following modifications on M2351:NOTE1: Disable GCC support on secure targets because of GCC bug (as of 9-2019-q4-major): In non-secure entry function, callee-saved registers must be restored, but they are incorrectly cleared at optimization level Os.
NOTE2: Disable IAR on secure targets because of IAR toolchain bug (as of IAR 8.32):
cmse_nonsecure_caller()
is not always inlined.Pull request type
Test results