Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mbed-os design docs #13623

Merged
merged 3 commits into from
Sep 21, 2020
Merged

Refactor mbed-os design docs #13623

merged 3 commits into from
Sep 21, 2020

Conversation

rajkan01
Copy link
Contributor

Summary of changes

  • Moved design docs from mbed-os/docs to corresponding library.

Impact of changes

None.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @LDong-Arm


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 16, 2020
@ciarmcom ciarmcom requested review from evedon, LDong-Arm and a team September 16, 2020 17:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@LDong-Arm @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-security @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@evedon
Copy link
Contributor

evedon commented Sep 17, 2020

It's not worth moving the empty README files. It's best to delete them

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2020

There are still there couple of readme that are empty as I can see after the latest update ?

@rajkan01
Copy link
Contributor Author

There are still there couple of readme that are empty as I can see after the latest update ?

Yes I just removed all of them

@ladislas
Copy link
Contributor

I would suggest having the .png and other images in an img directory inside docs instead of mixed with the .md.

@rajkan01
Copy link
Contributor Author

I would suggest having the .png and other images in an img directory inside docs instead of mixed with the .md.

This needs changes in all the .md file wherever it refers to the .png file. I would prefer we will do that in incremental changes

@adbridge
Copy link
Contributor

Ci started

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@rajkan01
Copy link
Contributor Author

@adbridge Could you check, why all travis-ci/xx expected state waiting for the status to be reported

@adbridge
Copy link
Contributor

@rajkan01 sorry I know nothing about how the travis stuff works. You could ask @jamesbeyond ?

@rajkan01
Copy link
Contributor Author

@jamesbeyond It seems to be some issue with travis-ci as it reported with waiting for the status to be reported, could you please help

@jamesbeyond
Copy link
Contributor

Hi, seem someone need to restart TravisCI ? @rajkan01 @adbridge
I do not have access to manage travisCI, I know @0xc0170 can do that, but seems he is OOO today?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2020

I restarted the job, https://travis-ci.org/github/ARMmbed/mbed-os/builds/728049669 . If it fails to report, I'll close and reopen the PR

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2020

It completed. I'll close now and reopen in few mins

@0xc0170 0xc0170 closed this Sep 21, 2020
@mergify mergify bot removed needs: CI release-type: patch Indentifies a PR as containing just a patch labels Sep 21, 2020
@0xc0170 0xc0170 reopened this Sep 21, 2020
@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Sep 21, 2020
@0xc0170 0xc0170 merged commit a02ea2f into ARMmbed:master Sep 21, 2020
@mergify mergify bot removed the ready for merge label Sep 21, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants