Cordio configure identity address #13622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pan-, thank you for your changes. |
0xc0170
previously approved these changes
Sep 16, 2020
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
Failure unrelated, but I recall seeing it few days ago. @jeromecoutant Wasn't this fixed or we got the recent changes that increased the size and causing it to fail? |
yes, should be fixed by #13587 |
|
Thanks, I did not realize this is for the feature branch. @pan- please rebase the feature branch |
| // The code should replace the random static address with the identity | ||
| // address if this is the case. | ||
| if (_db->get_local_identity_address() != gap.getRandomStaticAddress()) { | ||
| ble_error_t err =gap.setRandomStaticAddress(_db->get_local_identity_address()); |
There was a problem hiding this comment.
missing space after =
paul-szczepanek-arm
approved these changes
Sep 21, 2020
pan-
force-pushed
the
feature-ble-host-privacy
branch
from
cab0b0c
to
de531fd
Compare
pan-
force-pushed
the
cordio-configure-identity-address
branch
from
4b524e6
to
e2d1bf1
Compare
mergify
bot
dismissed
0xc0170’s stale review
Pull request has been modified.
…platform. The function to get it has been removed as this operation is driven by the security manager.
pan-
force-pushed
the
cordio-configure-identity-address
branch
from
e2d1bf1
to
a675ce6
Compare
This also ensure the random static address used by gap is the correct one.
pan-
force-pushed
the
cordio-configure-identity-address
branch
from
a675ce6
to
fd3bda3
Compare
|
Thanks for your review @paul-szczepanek-arm . I fixed the typo and rebased the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This adds new API to the cordio stack to set the identity address. It also change the random static address in GAP if it doesn't match the address in the security DB.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers