Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: remove status functionality #13619

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 16, 2020

Summary of changes

Unfortunately, we need to remove status functionality as it exposes an information
it should rather not. There is no other way we can do it in the pull request coming
from forks (most of our PRs are from forks). It is better if we use pass/failure what
Travis provides. The information are in the logs. It should always print the status info at
the very end. A test should have "echo Failed with a reason...."

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 16, 2020
@ciarmcom ciarmcom requested a review from a team September 16, 2020 09:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 16, 2020

I'll run some checks (astyle failures ,etc to see how it goes with the regular status updates).

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 16, 2020

To make this PR green , I would need to remove "required status checks for travis-ci/*". The Travis provides a report for each job: https://travis-ci.org/github/ARMmbed/mbed-os/builds/727646560 - this should be sufficient to review after the failure.

@ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers Please review

@0xc0170 0xc0170 requested a review from a team September 17, 2020 07:20
@0xc0170 0xc0170 changed the title WIP: Travis: remove status functionality Travis: remove status functionality Sep 17, 2020
@mergify mergify bot added the needs: work label Sep 17, 2020
@mergify
Copy link

mergify bot commented Sep 17, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 17, 2020

Rebased, testing now 2 new commits if this works as expected after the recent change to travis.

Unfortunately, we need to remove status functionality as it exposes an information
it should rather not. There is no other way we can do it in the pull request coming
from forks (most of our PRs are from forks). It is better if we use pass/failure what
Travis provides. The information are in the logs. It should always print the status info at
the very end. A test should have "echo Failed with a reason...."
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 23, 2020

I pushed an update, to fix OK license status for Travis.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 30, 2020

@harmut01 if I do not manage to get this green, could you take over to fix the license check and remove statuses from PRs ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 15, 2020

Travis green, looks like it is working now. However all Expected in travis should be removed from Github required statuses

@jamesbeyond @adbridge Please review

@adbridge
Copy link
Contributor

@0xc0170 how will we know going forward if a PR has failed travis checks if they are not 'required' ?

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as I can tell

@mergify mergify bot added needs: CI and removed needs: review labels Oct 15, 2020
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though I am very familiar with the TravisCI side of code,

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 15, 2020

@0xc0170 how will we know going forward if a PR has failed travis checks if they are not 'required' ?

There is one main Travis check - if you click , it will show you the matrix of jobs. So basically the same just one more click away, no test coverage loosing. Just this is the way it is supported by Travis

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 15, 2020

CI started

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 15, 2020

The required statuses cleaned - so pr head and travis only

@0xc0170 0xc0170 merged commit b3f4d3b into ARMmbed:master Oct 15, 2020
@0xc0170 0xc0170 deleted the fix_travis_status_token branch October 15, 2020 14:17
@mergify mergify bot removed the ready for merge label Oct 15, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants