Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: correct few Arduino pins value #13583

Merged
merged 6 commits into from
Sep 10, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Few minor corrections after internal tests:

  • NUCLEO_L552ZE_Q: D0 and D1 values were wrong
  • NUCLEO_F303ZE: D1 pin value was wrong
  • NUCLEO_F207ZG: SPI_MOSI alias value was wrong
  • DISCO_L072CZ_LRWAN1: A1/A3/A4/A5 values were wrong
  • NUCLEO_L433RC_P: D0 and D1 values were wrong
  • STM32G4: remove ADC support (this will be enable soon after implementation and tests)

Regards,

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 10, 2020
@ciarmcom ciarmcom requested a review from a team September 10, 2020 08:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Sep 10, 2020
@mbed-ci
Copy link

mbed-ci commented Sep 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit a17a481 into ARMmbed:master Sep 10, 2020
@mergify mergify bot removed the ready for merge label Sep 10, 2020
@jeromecoutant jeromecoutant deleted the PR_ARDUINO_PIN branch September 10, 2020 11:44
@AGlass0fMilk
Copy link
Member

AGlass0fMilk commented Sep 11, 2020

@jeromecoutant Ironically enough I started working with AnalogIn on my NUCLEO_G474RE today and encountered an assert due to the ADC regulator failing to initialize properly.

I then pulled the master branch and my build failed, someone had removed AnalogIn from G474!? I found this PR through git blame 😄

Can you comment on a timeline for re-enabling ADC on the G4 series? It's a pretty important feature for these mixed-signal MCUs...

I'd like to know any info on what could be causing the regulator enable issue in the HAL.

@jeromecoutant
Copy link
Collaborator Author

Yes, yesterday, I quickly tested basic ADC application.
It didn't work, so as I thought nobody has already tested it,
and as I didn't have the time right now, I removed the feature.
I will be happy to review the feature addition :-)

@AGlass0fMilk
Copy link
Member

Any idea why the regulator might be failing to start? I tried lowering the clock speed and extending the regulator enable wait loop but neither were effective.

@jeromecoutant
Copy link
Collaborator Author

@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants