Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Mbed TLS 2.19.1 #11493

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Update to Mbed TLS 2.19.1 #11493

merged 2 commits into from
Sep 17, 2019

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Sep 16, 2019 •
edited
Loading

Description

Mbed TLS 2.19.1 will correct an API mistake in the key exporter feature.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[X] Breaking change

Release Notes

The Mbed TLS key export feature's export keys callback, new in Mbed TLS 2.19.0, now requires use of const on its hello.random buffers (7th and 8th parameters). This is an API change.

f_export_keys_ext in ssl.h now has signature:

     int (*f_export_keys_ext)( void *, const unsigned char *,
                 const unsigned char *, size_t, size_t, size_t,
                 const unsigned char[32], const unsigned char[32],
                 mbedtls_tls_prf_types );

@ciarmcom ciarmcom requested review from a team September 16, 2019 17:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@ARMmbed/mbed-os-tls @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2019

@Patater 5.14.0-rc3 candidate?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2019

cc @adbridge

@Patater
Copy link
Contributor Author

Patater commented Sep 17, 2019

OK for patch release, probably. It is a breaking change vs rc2, so maybe better to get it into rc3 and avoid ever having done a "bad" release.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2019

It should be in rc3. What changes are expected for this:

2.19.1 is released.

?

We can run CI soon.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@Patater
tls: Update export keys callback to use const
60f383e 
Mbed TLS's export keys callback requires the hello.random (for both
server and client) to be const. Make the callbacks in Mbed OS that use
the key export feature use const to match.
@Patater Patater mentioned this pull request Sep 17, 2019
Merged
1 task
0xc0170
0xc0170 reviewed Sep 17, 2019
View reviewed changes
features/mbedtls/VERSION.txt Outdated
@@ -1 +1 @@
mbedtls-2.19.0
mbedtls-2.17.0-1047-gb2ab86ca1594
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that correct ? anyway will be updated here once the release is ready, won't be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the auto-version labeler not being able to find the tag. We have the tag now, and so this is now fixed.

@Patater
tls: Update to Mbed TLS 2.19.1
eb00fba 
Update Mbed TLS to Mbed TLS 2.19.1.
@Patater
Copy link
Contributor Author

Patater commented Sep 17, 2019 •
edited
Loading

Force pushed to use official tags instead of Patater ones. No code changes, so testing should still be valid.

@Patater Patater changed the title DO NOT MERGE Update to tls 2.19.1d0 Update to tls 2.19.1 Sep 17, 2019
@Patater Patater changed the title Update to tls 2.19.1 Update to Mbed TLS 2.19.1 Sep 17, 2019
@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 6a535d1 into ARMmbed:master Sep 17, 2019
@RonEld RonEld mentioned this pull request Sep 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgreen-arm dgreen-arm dgreen-arm approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Patater @ciarmcom @0xc0170 @mbed-ci @adbridge @dgreen-arm