Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal-printf: Add capability to run floating point tests manually #11455

Conversation

hugueskamba
Copy link
Collaborator

Description

There is currently no way for the CI to test features that are disabled by default. This PR provides a way to run the existing floating point tests manually by providing a configuration file that overwrite the default value of the attribute that disables floating point support in minimal-printf.

Floating point support is set to false by default here.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @evedon

Release Notes

@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@jamesbeyond @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is preferred way to run various CI jobs (having configuration in the codebase rather than in CI).

Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first step towards testing features that are disabled by default.
Next, we need to bring this in CI.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2019

cc @OPpuolitaival

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2019

Ci restarted, internal fault

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2019

@ARMmbed/mbed-os-test @jamesbeyond Please review

this will need CI enablement as the next step as mentioned earlier.

@jamesbeyond
Copy link
Contributor

This looks good to me. I guess @OPpuolitaival will need to figure out the possible way to enable it in the CI

@0xc0170 0xc0170 merged commit 8689c3f into ARMmbed:master Sep 19, 2019
@hugueskamba hugueskamba deleted the hk-add-ability-to-run-minimal-printf-floating-point-tests-manually branch November 18, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants