-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal-printf: Add capability to run floating point tests manually #11455
minimal-printf: Add capability to run floating point tests manually #11455
Conversation
@hugueskamba, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is preferred way to run various CI jobs (having configuration in the codebase rather than in CI).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first step towards testing features that are disabled by default.
Next, we need to bring this in CI.
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
Ci restarted, internal fault |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
@ARMmbed/mbed-os-test @jamesbeyond Please review this will need CI enablement as the next step as mentioned earlier. |
This looks good to me. I guess @OPpuolitaival will need to figure out the possible way to enable it in the CI |
Description
There is currently no way for the CI to test features that are disabled by default. This PR provides a way to run the existing floating point tests manually by providing a configuration file that overwrite the default value of the attribute that disables floating point support in minimal-printf.
Floating point support is set to false by default here.
Pull request type
Reviewers
@jamesbeyond @evedon
Release Notes