Cellular: Add API to clear CellularDevice #11414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AriParkkila, thank you for your changes. |
jarvte
approved these changes
Sep 5, 2019
|
This will be a nice addition as I've sometimes run into situations where I needed to clear the PDP contexts (e.g. sometimes when switching between APNs). |
|
We have seen connectivity issues with this PR when running internal cellular tests against our network simulator. We are currently investigating the issue. |
A new API `CellularDevice::clear()` to clean-up the modem to a default initial state. Function is virtual so it can be overridden. The default implementation clears all PDP contexts, but the the first one if that has APN defined as `nsapi.default-cellular-apn`. CellularStateMachine calls `clear()` to clean-up the modem on initial `connect()`, if the flag `cellular.clear-on-connect: true` is defined.
AriParkkila
force-pushed
the
cell-clear
branch
from
eebffa8 to
94dcab9
Compare
|
Internal tests working again without issues with the latest commit. |
mirelachirica
approved these changes
Sep 10, 2019
0xc0170
approved these changes
Sep 10, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
adbridge
added
the
release-version: 6.0.0-alpha-1
0xc0170
added
release-version: 5.15.0-rc1
and removed
release-version: 6.0.0-alpha-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new API
CellularDevice::clear()to clean-up the modem to a default initial state.Function is virtual so it can be overridden. The default implementation clears all PDP contexts,
but the the first one if that has APN defined as
nsapi.default-cellular-apn.CellularStateMachine calls
clear()to clean-up the modem on initialconnect(),if the flag
cellular.clear-on-connect: trueis defined.Description
Pull request type
Reviewers
@mirelachirica @jarvte
Release Notes
CellularStateMachinecallsCellularDevice::clear()to clean-up the modem on initialconnect().The previous functionality can be restored by defining the flag
cellular.clear-on-connect: false.