Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSSI getter fixed for ESP8266 #11304

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Conversation

AnttiKauppila
Copy link

@AnttiKauppila AnttiKauppila commented Aug 23, 2019

Description

ESP8266 RSSI getter issue fixed: #11252
Issue was caused because for scan() a callback was added for results and rssi() adopted same mechanism but code was not updated to reflect changes.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@star297
@ARMmbed/mbed-os-wan

Release Notes

@ciarmcom
Copy link
Member

@AnttiKauppila, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 26, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2019

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

This is now part of roll up PR: #11358

Please do not change this PR, or if you do, let us know asap

@0xc0170 0xc0170 removed the rollup PR label Aug 28, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

I suspect this has a failure with client test, restarting rollup and will report back

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

Client passed in the rollup without this PR, I'll start CI here to get results here as well

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

Internal error, code -11, restarting the build

cc @ARMmbed/mbed-os-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

Restarted CI

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

One example got breaking change, its fixed now but need to abort + restart current job here

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2019

Looks like all good !

@0xc0170 0xc0170 merged commit 56a8227 into ARMmbed:master Aug 29, 2019
@star297
Copy link
Contributor

star297 commented Oct 8, 2019

I still get RSSI result as 0

Using this example:
https://os.mbed.com/teams/mbed-os-examples/code/mbed-os-example-wifi/

Terminal output:

WiFi example
Mbed OS version 5.13.1

Scan:
Network: Molino Metz secured: None BSSID: 2C:5D:93:2:c4:b8 RSSI: -40 Ch: 3
Network: Molino secured: None BSSID: 2C:5D:93:9:86:8 RSSI: -85 Ch: 4
2 networks available.

Connecting to Molino Metz...
Success

MAC: 18:fe:34:a0:80:f7
IP: 192.168.1.42
Netmask: 255.255.255.0
Gateway: 192.168.1.1
RSSI: 0

Done

Not sure why the Mbed-os version is showing 5.13.1 my Revision History indicates 5.14.0-1

@AnttiKauppila
Copy link
Author

@star297 Example was not updated for 5.14. Should work now

@star297
Copy link
Contributor

star297 commented Oct 8, 2019

Thank's, just found that out, does work on Revision 6689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP8266 RSSI returns '0'
6 participants