Cellular: ublox cellular api refactoring #11292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mudassar-ublox, thank you for your changes. |
AriParkkila
suggested changes
Aug 23, 2019
| _at->cmd_start("AT+CFUN=4"); | ||
| _at->cmd_stop_read_resp(); | ||
| _at->at_cmd_discard("+CFUN", "=4"); | ||
| #endif | ||
| if (_at->get_last_error() == NSAPI_ERROR_OK) { |
| #endif | ||
|
|
||
| return _at->unlock_return_error(); | ||
| return _at->get_last_error(); |
| break; | ||
| } else { | ||
| _at.clear_error(); | ||
| wait_ms(1000); | ||
| } | ||
| } | ||
| t1.stop(); | ||
| _at.unlock(); | ||
| return _at.get_last_error(); |
|
@mudassar-ublox These changes are part of my PR: #11306. How do you want to proceed with this? |
Shall this be closed? |
|
It is fine to close it as changes are present in another pull request |
|
Closing as same changes present in PR #11306. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ublox cellular api refactoring. Updated methods with latest methods.
Pull request type
Reviewers
Release Notes