Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved partial profile to a subdirectory #11213

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Conversation

evedon
Copy link
Contributor

@evedon evedon commented Aug 13, 2019

Description

Moved the partial minimal-printf.json in a subdirectory mbed-os/tools/profiles/extensions because the tools currently don't support partial profiles.
Reverted 3010aaa.
Fixes #11209

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@madchutney @kjbracey-arm

Release Notes

@evedon
Copy link
Contributor Author

evedon commented Aug 13, 2019

I need to update the documentation for minimal-printf as well...

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2019

Once approved, we will run exporters at least 2-3x to make sure it is fixed :)

@ciarmcom ciarmcom requested review from kjbracey, madchutney and a team August 13, 2019 13:00
@ciarmcom
Copy link
Member

@evedon, thank you for your changes.
@kjbracey-arm @madchutney @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2019

Scheduled CI now

@mbed-ci
Copy link

mbed-ci commented Aug 13, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_pdmc-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2019

jenkins-ci/mbed-os-ci_pdmc-test

Wrong job configuration, can be ignored. The rest is good

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand profile being in the new place or older but happy to see cproject revert. Starting exporters one more time now

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2019

Exporters run 2x. should be all green on master soon!

@0xc0170 0xc0170 merged commit a64ab31 into ARMmbed:master Aug 14, 2019
@evedon
Copy link
Contributor Author

evedon commented Aug 14, 2019

@0xc0170 This PR depends on #11051
So target release should be 5.14

@evedon
Copy link
Contributor Author

evedon commented Aug 14, 2019

Tag updated to 5.14

Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this reverts the previous (breaking) change so ok to me.

@evedon evedon deleted the partial-profile branch August 15, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gnuarmeclipse: cxxsupport failures for few targets on master
6 participants