Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review follow-up mstd fixes #11211

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Review follow-up mstd fixes #11211

merged 3 commits into from
Aug 20, 2019

Conversation

kjbracey
Copy link
Contributor

Description

Minor fixes to #11039 - following up review comments from there.

  • Fix README.md typo
  • Drop dead ARMC5 std::reference_wrapper code
  • Fix mstd::not_fn

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Targeting 5.14.0, as fixing new feature.

Reviewers

@pan-

@ciarmcom ciarmcom requested review from pan- and a team August 13, 2019 11:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@kjbracey kjbracey changed the title Mstd Review follow-up mstd fixes Aug 13, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

CI started while finalizing reviews

Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbed-ci
Copy link

mbed-ci commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 73d6aa5 into ARMmbed:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants