Address comments on workaround for Mbed OS 2 CI build after Public #11114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugueskamba, thank you for your changes. |
Modify compilation API to provide a list of paths to exclude from the build.
hugueskamba
force-pushed
the
hk-fix-mbed-os-2-build
branch
from
189a6f2
to
14f3d0a
Compare
madchutney
requested changes
Jul 29, 2019
hugueskamba
force-pushed
the
hk-fix-mbed-os-2-build
branch
2 times, most recently
from
0629b9b
to
79d119f
Compare
* `_exclude_files_from_build` becomes a static method * Replace ternary expression with simple `if/else` statement Co-Authored-By: Graham Hammond <[email protected]>
hugueskamba
force-pushed
the
hk-fix-mbed-os-2-build
branch
from
79d119f
to
64007c7
Compare
Old habits die hard...Yes I will avoid doing that. |
madchutney
requested changes
Jul 29, 2019
madchutney
approved these changes
Jul 30, 2019
|
CI failing due to a different issue (trollius). |
evedon
pushed a commit
that referenced
this pull request
Aug 1, 2019
…11114) * Modify compilation API to provide a list of paths to exclude from the build. * `_exclude_files_from_build` becomes a static method * Replace ternary expression with simple `if/else` statement * Make unit test case for dirs exclusion independent of system files
evedon
pushed a commit
that referenced
this pull request
Aug 2, 2019
…11114) * Modify compilation API to provide a list of paths to exclude from the build. * `_exclude_files_from_build` becomes a static method * Replace ternary expression with simple `if/else` statement * Make unit test case for dirs exclusion independent of system files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The comments addressed can be found here
Pull request type
Reviewers
@madchutney @evedon
Release Notes