Cellular: add method to set authentication type to CellularContext #10694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarvte
force-pushed
the
set_authentication_type
branch
from
375e3a2
to
d61eeb4
Compare
|
Force pushed fix for unit test Valgrind run |
AriParkkila
reviewed
May 29, 2019
| * | ||
| * @param type enum AuthenticationType | ||
| */ | ||
| virtual void set_authentication_type(AuthenticationType type); |
AriParkkila
approved these changes
May 29, 2019
Authentication type must be able to set. It was hard coded to CHAP. Added unit tests for CellularContext to be able to add test for new function.
jarvte
force-pushed
the
set_authentication_type
branch
from
d61eeb4
to
8922eeb
Compare
|
@jarvte, thank you for your changes. |
AriParkkila
approved these changes
May 29, 2019
0xc0170
approved these changes
Jun 4, 2019
|
@AnttiKauppila waiting for your review |
AnttiKauppila
approved these changes
Jun 12, 2019
|
CI started. |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Looks like a license failure in CI, will restart. |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Authentication type must be able to set. It was hard coded to CHAP.
Added unit tests for CellularContext to be able to add test for new function.
Fix for issue: #10551
Pull request type
Reviewers
@AriParkkila
Release Notes
Add new method virtual void set_authentication_type(AuthenticationType type) to CellularContext so application can set the correct authentication type.