-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new mbedtls/timing.cpp creates double timing.o module #14759
Comments
@JojoS62 thank you for raising this issue.Please take a look at the following comments: Could you add some more detail to the description? A good description should be at least 25 words. NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'. This indicates to us that at least all the fields have been considered. |
Thanks for the report, what toolchain are you testing with? Although this comes from mbed tools :( I see there method |
Is this just a linker warning? From the code, it looks like it should be tool error (I wonder why CI did not catch this error). |
the binary image was created, and the target is running. But I'm not using the mbedtls, so the problem may have no effect. compiled with gcc9, using 'mbed compile' in a shell in ubuntu linux. |
We get a linker warning with the recently added timing module implementation for Mbed. This is because there is Mbed TLS also ships a file called timing.c, which we are including in Mbed OS also. With CLI 1, we get an error about unique object files because of the similarly named implementation files. Object file timing.o is not unique! It could be made from: mbed-os/connectivity/mbedtls/source/timing.c mbed-os/connectivity/mbedtls/platform/src/timing.cpp Rename the Mbed timing module implementation to timing_alt.cpp to avoid this naming conflict. Fixes: b8781e5 ("mbedtls: Add an alt implementation of timing") Fixes ARMmbed#14759
We get a linker warning with the recently added timing module implementation for Mbed. This is because there is Mbed TLS also ships a file called timing.c, which we are including in Mbed OS also. With CLI 1, we get an error about unique object files because of the similarly named implementation files. Object file timing.o is not unique! It could be made from: mbed-os/connectivity/mbedtls/source/timing.c mbed-os/connectivity/mbedtls/platform/src/timing.cpp Rename the Mbed timing module implementation to timing_mbed.cpp to avoid this naming conflict. Fixes: b8781e5 ("mbedtls: Add an alt implementation of timing") Fixes ARMmbed#14759
Description of defect
#14756 produces a linker warning because there exists already a timing.c:
Object file timing.o is not unique! It could be made from: mbed-os/connectivity/mbedtls/source/timing.c mbed-os/connectivity/mbedtls/platform/src/timing.cpp
Target(s) affected by this defect ?
Toolchain(s) (name and version) displaying this defect ?
arm-none-eabi-gcc (GNU Arm Embedded Toolchain 9-2020-q2-update) 9.3.1 20200408 (release)
What version of Mbed-os are you using (tag or sha) ?
b8781e5
What version(s) of tools are you using. List all that apply (E.g. mbed-cli)
mbed-cli v1
How is this defect reproduced ?
compile with mbed-cli v1
The text was updated successfully, but these errors were encountered: