Skip to content

Commit

Permalink
Merge pull request #11521 from u-blox/clear_after_sim_pin
Browse files Browse the repository at this point in the history
Bux fix: Context can be cleared using CGDCONT after sim ready state
  • Loading branch information
0xc0170 authored Sep 19, 2019
2 parents 4c9282f + 828fffb commit 11a34ec
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions features/cellular/framework/device/CellularStateMachine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,12 @@ bool CellularStateMachine::open_sim()
bool sim_ready = state == CellularDevice::SimStateReady;

if (sim_ready) {
#ifdef MBED_CONF_CELLULAR_CLEAR_ON_CONNECT
if (_cellularDevice.clear() != NSAPI_ERROR_OK) {
tr_warning("CellularDevice clear failed");
return false;
}
#endif
_cb_data.error = _network.set_registration(_plmn);
tr_debug("STM: set_registration: %d, plmn: %s", _cb_data.error, _plmn ? _plmn : "NULL");
if (_cb_data.error) {
Expand Down Expand Up @@ -345,13 +351,6 @@ bool CellularStateMachine::device_ready()
}
#endif // MBED_CONF_CELLULAR_DEBUG_AT

#ifdef MBED_CONF_CELLULAR_CLEAR_ON_CONNECT
if (_cellularDevice.clear() != NSAPI_ERROR_OK) {
tr_warning("CellularDevice clear failed");
return false;
}
#endif

send_event_cb(CellularDeviceReady);
_cellularDevice.set_ready_cb(0);

Expand Down Expand Up @@ -410,7 +409,6 @@ void CellularStateMachine::state_sim_pin()
retry_state_or_fail();
return;
}

if (_network.is_active_context()) { // check if context was already activated
tr_debug("Active context found.");
_status |= ACTIVE_PDP_CONTEXT;
Expand Down

0 comments on commit 11a34ec

Please sign in to comment.