Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nuvoton NU_M2354 platform #216

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Add Nuvoton NU_M2354 platform #216

merged 2 commits into from
Mar 23, 2020

Conversation

cyliangtw
Copy link
Contributor

Description

Add Nuvoton NUMAKER_M2354 target board support .
According to M2351 experience, target name (platform name + suffix) cannot exceed 20 chars.
So based on platform name “NUMAKER_M2354”, it will encounter the target name
“NUMAKER_M2354_NPSA_NS” over 20 chars.

Thus, short the platform name as “NU_M2354”.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@Ronny-Liu

@Ronny-Liu
Copy link

Ronny-Liu commented Feb 6, 2020 •
edited
Loading

target NU_M2354_NPSA_NS (ID: 1312) was set up in database.

@cyliangtw
Copy link
Contributor Author

cyliangtw commented Mar 13, 2020 •
edited
Loading

@mark-edgeworth
@MarceloSalazar
Is there any concern on this PR ?

@MarceloSalazar MarceloSalazar self-requested a review March 20, 2020 11:16
MarceloSalazar
MarceloSalazar approved these changes Mar 20, 2020
View reviewed changes
Copy link

@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm target ID and NU_M2354 is in the online database

@madchutney
Copy link
Contributor

@MarceloSalazar It appears that this board is listed as NU_M2354_NPSA_NS in the online database, should this be corrected?

@MarceloSalazar
Copy link

It's been corrected. Should be fine now.

@mark-edgeworth mark-edgeworth merged commit fb0aca7 into ARMmbed:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madchutney madchutney madchutney approved these changes

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyliangtw @Ronny-Liu @madchutney @MarceloSalazar @mark-edgeworth