M2354: Support Nuvoton M2354 #124
Conversation
ccli8
force-pushed
the
nuvoton_mbed_m2354_tfm-1.3_wip
branch
from
e627452
to
036d47e
Compare
There was a problem hiding this comment.
@ccli8 Thanks for the PR, it looks perfect to me!
Could you please add NU_M2354 to CI:
.travis.yml:
# NU_M2354
- <<: *compile-tests
name: "Compile Regression tests - NU_M2354"
env: TARGET_NAME=NU_M2354 CACHE_NAME=NU_M2354.circleci/config.yml:
- compile:
target: "NU_M2354"
then we'll be able to see build results with Mbed CLI 1 & 2 in the PR.
@ccli8 Thanks for letting us know. We're also planning to update GCC to 10 2021.07, so let me raise a PR to update GCC used in CI (earlier comment) first. |
1. Change trusted-firmware-m download path to Nuvoton forked repository (nuvoton_mbed_m2354_tfm-1.3)
2. Add post-build copy paths specific to M2354 (tfm_ns_import.yaml)
3. Detect python/python3 command name across platforms
4. Enable Mbed CLI 2 (CMake)
5. Enable Greentea test path
(1) Disable PSA compliance test, which M2354 hasn't supported yet
(2) Add compare log (REGRESSION.log only)
6. Update CI configuration
7. Update readme
NOTE1: Dummy the script for erasing flash storage for Greentea test because drag-n-drop flash invokes Mass Erase which will erase the whole flash.
NOTE2: As ITS/PS/NV counter regions are changed (flash_layout.h), the script for erasing flash storage needs update accordingly. But this can skip with above.
NOTE3: To cover root-RSA-3072.pem missing in TF-M install (https://developer.trustedfirmware.org/T957), change its source path for copy:
From: install/image_signing/keys/root-RSA-3072.pem
To: ../bl2/ext/mcuboot/root-RSA-3072.pem
NOTE4: For PSA Firmware Update test, in CMakeLists (for Mbed CLI 2), test lib tfm_test_suite_fwu_ns is needed.
NOTE5: REGRESSION.log needs to contain PSA Firmware Update test.
ccli8
force-pushed
the
nuvoton_mbed_m2354_tfm-1.3_wip
branch
from
036d47e
to
2d3cd7e
Compare
|
@LDong-Arm Updated |
Thanks. Now waiting for builds to finish. The CI is build-only (no running), and older versions of GCC can still build it, just the image is invalid. So I think we can get this PR in without waiting for my toolchain upgrade PR. |
|
@Patater It would be good to get this in before migrating to GitHub Actions for CI? |
This PR tries to upstream M2354 port to mainstream. It includes:
nuvoton_mbed_m2354_tfm-1.3) for M2354tfm_ns_import.yaml)NOTE1: For upgrade to TF-M 1.4 for M2354, change branch to
nuvoton_mbed_m2354_tfm-1.4.NOTE2: About GCC toolchain, 9 2020-q2-update (and earlier)/10-2020-q4-major have issues on -Os/-mcmse respectively. This PR is verified with 10 2021.07.
NOTE3: If you run
TEST_Stests, you will meet TFM_SP_PS_TEST test broken failure. It is caused by TFM_SP_PS_TEST stack overflow.