-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review wanted] Async greentea-client support #149
Conversation
Rebase 29-01-2016
Merge timeout and host test name in one macro
KiVi - Key Value parser {{key;value}} (This gonna be a industrial standard in IoT in 2027 ;)
We will scan for {{k;v} (no second bracket)
Before we go further with a review, are these changes considered to be breaking? I am asking mainly because the test env files should be moved as a note quoted above. Looking at the changes they are breaking. We should sync about this, how to proceed (move test files plus this update). |
How does this relate to https://github.com/ARMmbed/utest? |
The default greentea handlers in utest will need to be updated to reflect the changes here. |
#endif | ||
#define GREENTEA_TSUITE_RESULT(RESULT) notify_completion(RESULT); | ||
#define GREENTEA_TCASE_START(TESTCASE_UD) notify_testcase_start(TESTCASE_UD); | ||
#define GREENTEA_TCASE_FINISH(TESTCASE_UD,SUCCESS) notify_testcase_finish(TESTCASE_UD,SUCCESS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Macros? There are no macros where we're going.
They obscure type information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could we please spare the three more letters and call this GREENTEA_TESTCASE_*
?
Apart from some cosmetic changes, 👍 from me.
|
This is breaking everything, tests in yotta modules and host tests. |
DONE: Macros? There are no macros where we're going. They obscure type information. DONE: Also, could we please spare the three more letters and call this GREENTEA_TESTCASE_*? DONE: Maybe we can make this more robust, by placing this in a while loop until _key is equal to __sync?
Prevented tok_eof expectation after tok_close received
utest will do test case reporting heavy lifting
I'm closing this PR because it is obsolete and was used to present Async feature idea. |
Description
Changes related to async feature bundle:
test_env
macros simplified.{{key;value}}
.sync
support.Corresponding changes
Corresponding changes in
mbedhtrun
are here: ARMmbed/htrun#65Note that for now Greentea doesn't support new
mbedhtrun
scheme but I will add it.Key-value protocol (KiVi)
{{KEY;VALUE}}}
.sync
- handshake, sync event.end
- end of test suite execution event.exit
- last event from DUT (Betweenend
andexit
LCOV events may appear).coverage_start
- LCOV events.testcase_start
&testcase_finish
- test case mark events.New test_env implementation
New macros
Note: This will be in the future extracted to separate module e.g.
greentea-client
. C++ Wrapper will be added.Naming convention
test suite
- a binary containing test cases we execute on hardware.test case
- equivalent of a test case inutest
.DUT test case idiom
TODO
--digest
support)Example implementation