Skip to content

Commit

Permalink
Disable shorten 64 to 32 error for arm64 (do not make it fatal) (proj…
Browse files Browse the repository at this point in the history
…ect-chip#23237)

* Disable shorten 64 to 32 error for arm64 (do not make it fatal)

* Add a CI target that would catch these errors in future updates

* Restyle

* Fix typo and link to the pigweed update PR
  • Loading branch information
andy31415 authored and adbridge committed Nov 18, 2022
1 parent ba4347a commit cabc68a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/examples-linux-arm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ jobs:
--target linux-arm64-chip-tool-ipv6only-clang \
--target linux-arm64-lock-clang \
--target linux-arm64-minmdns-clang \
--target linux-arm64-light-rpc-ipv6only-clang \
--target linux-arm64-thermostat-no-ble-clang \
build \
"
Expand Down
9 changes: 9 additions & 0 deletions build/config/compiler/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,15 @@ config("strict_warnings") {
"-Wshorten-64-to-32",
"-Wformat-type-confusion",
]

# TODO: can make this back fatal in once pigweed updates can be taken again.
# See https://github.com/project-chip/connectedhomeip/pull/22079
#
# Currently `./scripts/build/build_examples.py --target linux-arm64-light-rpc-ipv6only-clang build`
# fails in third_party/pigweed/repo/pw_protobuf
if (current_cpu == "arm64" && current_os == "linux") {
cflags += [ "-Wno-error=shorten-64-to-32" ]
}
}

if (!is_asan && (current_os == "linux" || current_os == "android")) {
Expand Down

0 comments on commit cabc68a

Please sign in to comment.