[AAELF64][PAUTHABI64] Assign PAuthABI relocation codes. #227
Conversation
smithp35
force-pushed
the
movepauthrelocs
branch
from
12eb4d5 to
27491c9
Compare
| @@ -698,7 +700,7 @@ Static Data relocations | |||
| | | | | | | |||
| | | | | | | |||
| +=============+==========================+================+=====================================================+ | |||
| | 0xE100 | R\_AARCH64\_AUTH\_ABS64 | ``PAUTH(S+A)`` | Signing schema encoded in the contents of the place | | |||
| | 0x244 | R\_AARCH64\_AUTH\_ABS64 | ``PAUTH(S+A)`` | Signing schema encoded in the contents of the place | | |||
There was a problem hiding this comment.
We are having two relocations named R_AARCH64_AUTH_ABS64 with different ids (static and dynamic). Should this be named R_AARCH64_AUTH_ABS64_STATIC as otherwise there is an ambiguity?
There was a problem hiding this comment.
This is the same as R_AARCH64_ABS64 which can be both a static and dynamic relocation. I followed that convention as R_AARCH64_AUTH_ABS64 is its PAuth equivalent.
Changing codes is possible but I thought it better to stick the existing convention.
There was a problem hiding this comment.
It's not the code, it's the name. Essentially we cannot put these two relocations into a single enum – we'd need to rename one entry.
There was a problem hiding this comment.
Actually I think it is the code, and I've made a mistake, sorry.
The intention is that the name and code remain the same. In the original both had 0xE100, but in the new one I used the first code in the dynamic range, it needed to retain its original 0x244. I'll update the pull request.
There was a problem hiding this comment.
I've updated the value. I had it right in aaelf64.rst but not here.
smithp35
force-pushed
the
movepauthrelocs
branch
from
27491c9 to
fadf88f
Compare
ARM-software/abi-aa#227 changes IDs of `R_AARCH64_AUTH_ABS64` and `R_AARCH64_AUTH_RELATIVE` in PAuth ABI specification from draft ones (`0xe100` and `0xe200`) to final ones (`0x244` and `0x411`). This patch changes the values in llvm correspondingly.
ARM-software/abi-aa#227 changes IDs of `R_AARCH64_AUTH_ABS64` and `R_AARCH64_AUTH_RELATIVE` in PAuth ABI specification from draft ones (`0xe100` and `0xe200`) to final ones (`0x244` and `0x411`). This patch changes the values in llvm correspondingly.
ARM-software/abi-aa#227 changes IDs of `R_AARCH64_AUTH_ABS64` and `R_AARCH64_AUTH_RELATIVE` in PAuth ABI specification from draft ones (`0xe100` and `0xe200`) to final ones (`0x244` and `0x411`). This patch changes the values in llvm correspondingly.
|
Just to note: the current implementation in LLVM is done according to this spec. |
|
I'll set a review deadline for 12/05/2024, I'll merge unless there are any objections. |
1 similar comment
|
I'll set a review deadline for 12/05/2024, I'll merge unless there are any objections. |
Now that there will be a concrete implementation of PAuthABI in upstream LLVM we need to move the PAuthABI relocation codes out of the space reserved for private experiments to their final codes. These are in the range of codes already reserved for the PAuthABI in AAELF64. The description of the operations will remain in the PAuthABI64 as this remains an extension.
smithp35
force-pushed
the
movepauthrelocs
branch
from
fadf88f to
3edb0bf
Compare
|
Rebased changes prior to merge |
Now that there will be a concrete implementation of PAuthABI in upstream LLVM we need to move the PAuthABI relocation codes out of the space reserved for private experiments to their final codes. These are in the range of codes already reserved for the PAuthABI in AAELF64.
The description of the operations will remain in the PAuthABI64 as this remains an extension.