Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pauthabielf64] Move signed GOT relocs from private to public space #298

Open
kovdan01 opened this issue Nov 25, 2024 · 4 comments · May be fixed by #300
Open

[pauthabielf64] Move signed GOT relocs from private to public space #298

kovdan01 opened this issue Nov 25, 2024 · 4 comments · May be fixed by #300

Comments

@kovdan01
Copy link

Currently, both signed GOT-generating relocations and dynamic relocations for signed GOT use codes from private space:

Backend support for signed GOT was landed in llvm: llvm/llvm-project#113811. So, it's probably worth moving the relocation codes to public space.
@kovdan01
Copy link
Author

Tagging @smithp35 @asl

@smithp35
Copy link
Contributor

Thanks for raising, I'll aim to get a PR up this week.

smithp35 added a commit to smithp35/abi-aa that referenced this issue Nov 29, 2024
@smithp35
[pauthabi64][aaelf64] Move PAuth GOT relocs out of private space
6b15b45 
In the initial draft relocations for signing GOT entries were
defined in the private space reserved for experiments. It was not
known if these relocations would be useful as if RELRO is supported
the GOT does not need to be signed. There is now at least one user
of the GOT signing relocations so we should move the relocations
out of the private space and into the space reserved for the
PAuthABI.

This PR includes relocations added in
ARM-software#295

Fixes: ARM-software#298
@smithp35 smithp35 linked a pull request Nov 29, 2024 that will close this issue
Open
@smithp35
Copy link
Contributor

#300 To move relocations to space reserved for PAuthABI.

@kovdan01
Copy link
Author

kovdan01 commented Dec 1, 2024

#300 To move relocations to space reserved for PAuthABI.

Thanks @smithp35! Submitted a corresponding PR to llvm-project llvm/llvm-project#118214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pauthabi64][aaelf64] Move PAuth GOT relocs out of private space smithp35/abi-aa
2 participants
@kovdan01 @smithp35