MNT: Change naming to MET as its plotting met data. #653
Conversation
zssherman
commented
Apr 4, 2023
•
zssherman
commented
- Closes Example Incorrect #652
- Documentation reflects changes
- PEP8 Standards or use of linter
zssherman
requested review from
rcjackson and
AdamTheisen
and removed request for
mgrover1
|
Ooo yeah good point! Will fix that now |
|
@rcjackson Did pysp2 update anything that would change the waveform stats calculation? |
|
Seeing some unit changes etc recently to it. |
|
@zssherman if we are changing this to just be a simple plot of the time series data, we can remove the LCL calculations from this example. I was somewhat thinking of this the other way around in that we should update the example to plot the SONDE time series with the LCL plotted in a plot of the altitude or something like that. I think that is what @rcjackson was maybe intending to do with this one. Thoughts? |
|
@AdamTheisen Ah makes sense! I can switch things around to be what was originally intended! |
|
@AdamTheisen Example has been updated for sonde data. Updating the unit tests now to match the pysp2 changes that are failing the CI. |
|
@zssherman can you update those values in the test suite? |
|
@mgrover1 Done |
|
Confused on this class init failures for only python 3.8: |
|
Ah so all tests failing for that base error are all older xarray version its looks like using base parameter in resample. |
|
@AdamTheisen @mgrover1 See other comments above. Do we drop 3.8 as we are three ahead with 3.9, 3.10 and 3.11 or do we find a work around for this base error in resampling. |
|
Let's pin pandas<2.0... it is an issue on the xarray/pandas/flox side. We should consider pinning version in tests/such |
|
@mgrover1 Sounds like a plan! |
|
@mgrover1 I can't remember if that syntax is right for requirements.txt. I know it is for the .yml. Also two numpy installs removed one of them. |
|
And do you have the issue or where you found the info on the pandas/flox issue. |
|
@mgrover1 Cool seems to be working! Just the usual stalled tests. |
|
@AdamTheisen @mgrover1 Once you both think this is good to merge, I can push it through |
