Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ark-cli: Refactor to depend on crates from ark-rust not arklib #15

Closed
kirillt opened this issue Mar 12, 2024 · 0 comments · Fixed by #24
Closed

ark-cli: Refactor to depend on crates from ark-rust not arklib #15

kirillt opened this issue Mar 12, 2024 · 0 comments · Fixed by #24
Assignees
@tareknaser

Comments

@kirillt
Copy link
Member

kirillt commented Mar 12, 2024

We've just moved ark-cli from separate repo into to the crate in this repo:

At the moment, it still depends on arklib which is previous version of ark-rust. Before we could archive the arklib repo, we need to sort out dependencies and point ark-cli to individual crates.

Also, just cli should be better name since all crates belong to ark family. The binary should be named ark-cli though.
@kirillt kirillt mentioned this issue Mar 12, 2024
Merged
@tareknaser tareknaser self-assigned this Mar 12, 2024
@kirillt kirillt changed the title Refactor ark-cli to depend on crates from ark-rust not arklib fs-cli: Refactor to depend on crates from ark-rust not arklib Apr 3, 2024
@kirillt kirillt changed the title fs-cli: Refactor to depend on crates from ark-rust not arklib ark-cli: Refactor to depend on crates from ark-rust not arklib Apr 3, 2024
tareknaser pushed a commit to tareknaser/ark-rust that referenced this issue Apr 6, 2024
@kirillt @tareknaser
ARK-Builders#15: Persisted index and metadata storage (#8)
41752ba
tareknaser added a commit to tareknaser/ark-rust that referenced this issue Apr 7, 2024
@tareknaser
fix(ark-cli): use ark-rust_hot_fix branch of arklib
231a6ce 
The branch `ark-rust_hot_fix` contains a hot fix where we use the same commit specified when writing `ark-cli` but with pinning `image` crate to the correct version so that `ark-rust` can compile

This is just a hot fix. `arklib` shouldn't be even a dependency of any `ark-rust` crate. See ARK-Builders#15 for more information

Signed-off-by: Tarek <[email protected]>
tareknaser pushed a commit that referenced this issue Apr 8, 2024
@kirillt @tareknaser
#15: Persisted index and metadata storage (#8)
6030661
tareknaser added a commit that referenced this issue Apr 8, 2024
@tareknaser
fix(ark-cli): use ark-rust_hot_fix branch of arklib
5cf25df 
The branch `ark-rust_hot_fix` contains a hot fix where we use the same commit specified when writing `ark-cli` but with pinning `image` crate to the correct version so that `ark-rust` can compile

This is just a hot fix. `arklib` shouldn't be even a dependency of any `ark-rust` crate. See #15 for more information

Signed-off-by: Tarek <[email protected]>
@tareknaser tareknaser mentioned this issue Apr 8, 2024
Merged
tareknaser pushed a commit to tareknaser/ark-rust that referenced this issue Apr 9, 2024
@kirillt @tareknaser
ARK-Builders#15: Persisted index and metadata storage (#8)
cafffad
kirillt pushed a commit that referenced this issue Apr 10, 2024
@tareknaser @kirillt
fix(ark-cli): use ark-rust_hot_fix branch of arklib
452edb6 
The branch `ark-rust_hot_fix` contains a hot fix where we use the same commit specified when writing `ark-cli` but with pinning `image` crate to the correct version so that `ark-rust` can compile

This is just a hot fix. `arklib` shouldn't be even a dependency of any `ark-rust` crate. See #15 for more information

Signed-off-by: Tarek <[email protected]>
kirillt added a commit that referenced this issue Apr 10, 2024
@kirillt
#15: Persisted index and metadata storage (#8)
99e8f34
kirillt pushed a commit that referenced this issue Apr 10, 2024
@tareknaser @kirillt
fix(ark-cli): use ark-rust_hot_fix branch of arklib
233d8c1 
The branch `ark-rust_hot_fix` contains a hot fix where we use the same commit specified when writing `ark-cli` but with pinning `image` crate to the correct version so that `ark-rust` can compile

This is just a hot fix. `arklib` shouldn't be even a dependency of any `ark-rust` crate. See #15 for more information

Signed-off-by: Tarek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tareknaser tareknaser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ark-cli: Depend on Workspace Crates Instead of arklib ARK-Builders/ark-core
2 participants
@kirillt @tareknaser