Skip to content

Commit

Permalink
fix(ci): disable benchmarks for all crates in the workspace
Browse files Browse the repository at this point in the history
The bench feature has been disabled for all crates within the workspace to resolve an issue encountered during CI testing.

The reason is that by default, Cargo implicitly adds a libtest benchmark harness to any crate when benchmarking, to handle any #[bench] functions, even if we have none. This ruins our Benchmarking CI with the error (Unrecognized option: save-baseline) in the logs.

For more details: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options

Signed-off-by: Tarek <[email protected]>
  • Loading branch information
tareknaser authored and kirillt committed Mar 16, 2024
1 parent d88e87a commit 8e0a80b
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 0 deletions.
5 changes: 5 additions & 0 deletions data-error/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ name = "data-error"
version = "0.1.0"
edition = "2021"

[lib]
name = "data_error"
crate-type = ["rlib"]
bench = false

[dependencies]
thiserror = "1"
reqwest = "0.11.11"
Expand Down
4 changes: 4 additions & 0 deletions data-json/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name = "data-json"
version = "0.1.0"
edition = "2021"

[lib]
name = "data_json"
crate-type = ["rlib"]
bench = false

[dependencies]
serde_json = "1.0.82"
Expand Down
1 change: 1 addition & 0 deletions data-link/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ edition = "2021"
[lib]
name = "data_link"
crate-type = ["rlib"]
bench = false

[dependencies]
fs-atomic-light = { path = "../fs-atomic-light" }
Expand Down
1 change: 1 addition & 0 deletions data-pdf/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ edition = "2021"
[lib]
name = "data_pdf"
crate-type = ["rlib"]
bench = false

[dependencies]
once_cell = "1.16.0"
Expand Down
1 change: 1 addition & 0 deletions fs-atomic-light/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ edition = "2021"
[lib]
name = "fs_atomic_light"
crate-type = ["rlib"]
bench = false

[dependencies]
data-error = { path = "../data-error" }
1 change: 1 addition & 0 deletions fs-atomic-versions/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ edition = "2021"
[lib]
name = "fs_atomic_versions"
crate-type = ["rlib"]
bench = false

[dependencies]
data-error = { path = "../data-error" }
Expand Down
4 changes: 4 additions & 0 deletions fs-metadata/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name = "fs-metadata"
version = "0.1.0"
edition = "2021"

[lib]
name = "fs_metadata"
crate-type = ["rlib"]
bench = false

[dependencies]
data-error = { path = "../data-error" }
Expand Down
4 changes: 4 additions & 0 deletions fs-properties/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name = "fs-properties"
version = "0.1.0"
edition = "2021"

[lib]
name = "fs_properties"
crate-type = ["rlib"]
bench = false

[dependencies]
data-error = { path = "../data-error" }
Expand Down
4 changes: 4 additions & 0 deletions fs-storage/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,9 @@ name = "fs-storage"
version = "0.1.0"
edition = "2021"

[lib]
name = "fs_storage"
crate-type = ["rlib"]
bench = false

[dependencies]

0 comments on commit 8e0a80b

Please sign in to comment.