feat(ark-cli): update parameters with default_value in clap

Signed-off-by: Tarek <[email protected]>

ark-cli/src/commands/file/append.rs

@@ -23,7 +23,13 @@ pub struct Append {
     id: String,
     #[clap(help = "Content to append to the resource")]
     content: String,
-    #[clap(short, long, value_enum, help = "Format of the resource")]
+    #[clap(
+        short,
+        long,
+        value_enum,
+        default_value = "raw",
+        help = "Format of the resource"
+    )]
     format: Option<Format>,
     #[clap(short, long, value_enum, help = "Storage kind of the resource")]
     kind: Option<StorageType>,
@@ -35,12 +41,13 @@ impl Append {
             translate_storage(&Some(self.root_dir.to_owned()), &self.storage)
                 .ok_or(AppError::StorageNotFound(self.storage.to_owned()))?;
 
+        // FIXME: Why do we have `self.kind` and `self.storage`? Both are used to determine the storage type
         let storage_type = storage_type.unwrap_or(match self.kind {
             Some(t) => t,
             None => StorageType::File,
         });
 
-        let format = self.format.unwrap_or(Format::Raw);
+        let format = self.format.unwrap();
 
         let mut storage = Storage::new(file_path, storage_type)?;
 

ark-cli/src/commands/list.rs

@@ -179,9 +179,6 @@ impl List {
         let no_tags = "NO_TAGS";
         let no_scores = "NO_SCORE";
 
-        // FIXME: We should use a table library to print this.
-        //        probably `comfy-table`
-
         let longest_path = storage_entries
             .iter()
             .map(|entry| {

ark-cli/src/commands/monitor.rs

@@ -7,16 +7,17 @@ use crate::{monitor_index, AppError};
 pub struct Monitor {
     #[clap(value_parser, help = "Path to the root directory")]
     root_dir: Option<PathBuf>,
-    // FIXME: help message should specify what metric the interval is in
-    #[clap(help = "Interval to check for changes")]
+    #[clap(
+        default_value = "1000",
+        help = "Interval to check for changes in milliseconds"
+    )]
     interval: Option<u64>,
 }
 
 impl Monitor {
     pub fn run(&self) -> Result<(), AppError> {
-        // FIXME: 1000 should be the default value in clap configuration
-        //        so users know
-        let millis = self.interval.unwrap_or(1000);
+        // SAFETY: interval is always Some since it has a default value in clap
+        let millis = self.interval.unwrap();
         monitor_index(&self.root_dir, Some(millis))
     }
 }

ark-cli/src/commands/storage/list.rs

@@ -12,8 +12,9 @@ pub struct List {
     root_dir: Option<PathBuf>,
     #[clap(help = "Storage name")]
     storage: Option<String>,
-    #[clap(short, long, help = "TODO: what is this flag for?")]
-    versions: Option<bool>,
+    // TODO: What is the purpose of this field? Add a help message to clarify.
+    #[clap(short, long, action = clap::ArgAction::SetTrue)]
+    versions: bool,
     #[clap(short, long, value_enum, help = "Storage kind of the resource")]
     kind: Option<StorageType>,
 }
@@ -27,7 +28,7 @@ impl List {
                     "Storage was not provided".to_owned(),
                 ))?;
 
-        let versions = self.versions.unwrap_or(false);
+        let versions = self.versions;
 
         let (file_path, storage_type) =
             translate_storage(&self.root_dir, storage)

ark-cli/src/commands/storage/mod.rs

@@ -2,6 +2,8 @@ use clap::Subcommand;
 
 mod list;
 
+// FIXME: We should use new `fs-storage` crate to handle storage operations
+
 /// Available commands for the `storage` subcommand
 #[derive(Subcommand, Debug)]
 pub enum Storage {