-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Folder creation capability #41
Conversation
aecb39e
to
45b9986
Compare
Looks good. Let's also enhance this feature in ARK mode ("Roots" tab):
We could also implement this feature in this PR: |
And let's also take #51 in the scope, copying the checklist from there. General points:
File-picking mode:
|
* [feature] Automatically pin folders (Make Root/Favorite) when creating new folder in ARK mode: #41 (comment)
@kirillt Both enhancement in ARK mode and folder pinning from classical view have been implemented. Please check out the demo video in the PR's description. |
@kirillt Since the changes in this PR are already large, and the scope of the changes is growing bigger and bigger, I suggest making this enhancement in a separate PR :). I can take care of it. |
|
||
findViewById<MaterialButton>(R.id.btn_open_file_mode).setOnClickListener { | ||
resolvePermissions() | ||
ArkFilePickerFragment | ||
.newInstance(getFilePickerConfig(mode = ArkFilePickerMode.FILE)) | ||
.show(supportFragmentManager, null) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a sample of how to open the picker in FILE
mode.
Great job, thank you |
Support folder creation capability.
Folder creation capability ark-filepicker#5
Video: https://recordit.co/M9pVoU7eJT
Pin folders from classical view into
Roots
tab:FilePicker: Pin folders from classical view into "Roots" tab #49
Video: https://recordit.co/PFTuksgTD8
Automatically pin a folder (Make Root/Favorite) when creating new folder in
Roots
tab: [feature] Folder creation capability #41 (comment)Video: https://recordit.co/PFTuksgTD8