Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#333: Root folder suggestions #347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#333: Root folder suggestions #347

wants to merge 1 commit into from

Conversation

kirillt
Copy link
Member

@kirillt kirillt commented Apr 18, 2023 •
edited
Loading

#333
Updated requirements:

  • folder suggesting dialog must be separate from scan dialog
  • folder suggesting dialog must be presented after scan dialog
  • if any of suggested folders is already added, it should be excluded from suggestions
  • if no folders remain to suggest, folder suggesting dialog can be omitted

Would be nice to have:

  • if the app can't find .ark-global folder with a list of roots inside, it should ask for scan
  • if there is .ark-global folder with a list of roots inside, the app shouldn't ask for scan
  • disk root causes problems, should be filtered when added folders in any moment
    one kind of problems is blank screen when I try to unfold it (in folders screen)

@kirillt kirillt temporarily deployed to Development April 18, 2023 07:58 — with GitHub Actions Inactive
@kirillt kirillt temporarily deployed to Development April 18, 2023 08:01 — with GitHub Actions Inactive
@kirillt kirillt temporarily deployed to Development April 18, 2023 08:01 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kirillt kirillt self-assigned this Oct 21, 2023
@kirillt kirillt requested a review from hieuwu November 18, 2023 06:20
@kirillt kirillt assigned hieuwu and unassigned kirillt Nov 18, 2023
@kirillt kirillt force-pushed the 333-default-folders branch from b875933 to 7ec6a6d Compare February 12, 2024 11:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieuwu hieuwu Awaiting requested review from hieuwu

At least 1 approving review is required to merge this pull request.

Assignees

@hieuwu hieuwu

Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirillt @hieuwu