Migrate hardcoded dependencies to version catalog #82

tuancoltech · 2024-10-28T16:00:31Z

Migrate hardcoded dependencies to version catalog.

[Gradle version catalogs](https://docs.gradle.org/current/userguide/platforms.html) enable you to add and maintain dependencies and plugins in a scalable way. Using Gradle version catalogs makes managing dependencies and plugins easier when you have [multiple modules](https://developer.android.com/topic/modularization). Instead of hardcoding dependency names and versions in individual build files and updating each entry whenever you need to upgrade a dependency, you can create a central version catalog of dependencies that various modules can reference in a type-safe way with Android Studio assistance.

https://app.asana.com/0/1207819682524134/1208308884950165
https://developer.android.com/build/migrate-to-catalogs

shubertm · 2024-11-04T08:24:13Z

app/build.gradle


-    implementation 'com.github.kirich1409:viewbindingpropertydelegate-noreflection:1.5.9'
+    implementation(libraries.viewbinding.property.delegate)


Suggested change

implementation(libraries.viewbinding.property.delegate)

implementation(libraries.viewbinding.property.delegate.noreflection)

shubertm · 2024-11-04T08:25:09Z

app/build.gradle


-    implementation 'dev.arkbuilders:arkfilepicker:0.1.1'
-    implementation 'dev.arkbuilders:arklib:0.3.3'
+    implementation(libraries.arkbuilder.arkfilepicker)


Suggested change

implementation(libraries.arkbuilder.arkfilepicker)

implementation(libraries.arkbuilders.arkfilepicker)

shubertm · 2024-11-04T08:25:43Z

app/build.gradle

-    implementation 'dev.arkbuilders:arkfilepicker:0.1.1'
-    implementation 'dev.arkbuilders:arklib:0.3.3'
+    implementation(libraries.arkbuilder.arkfilepicker)
+    implementation(libraries.arkbuilder.arklib)


Suggested change

implementation(libraries.arkbuilder.arklib)

implementation(libraries.arkbuilders.arklib)

shubertm · 2024-11-04T08:56:23Z

gradle/libs.versions.toml

+androidx-test-espresso = { group = "androidx.test.espresso", name = "espresso-core", version.ref = "androidXTestEspresso" }
+skydoves-balloon = { group = "com.github.skydoves", name = "balloon", version.ref = "skydovesBalloon" }
+flexbox = { group = "com.google.android.flexbox", name = "flexbox", version.ref = "flexbox" }
+arkbuilder-arkfilepicker = { group = "dev.arkbuilders", name = "arkfilepicker", version.ref = "arkFilepicker" }


Suggested change

arkbuilder-arkfilepicker = { group = "dev.arkbuilders", name = "arkfilepicker", version.ref = "arkFilepicker" }

arkbuilders-arkfilepicker = { group = "dev.arkbuilders", name = "arkfilepicker", version.ref = "arkFilepicker" }

shubertm · 2024-11-04T08:56:52Z

gradle/libs.versions.toml

+skydoves-balloon = { group = "com.github.skydoves", name = "balloon", version.ref = "skydovesBalloon" }
+flexbox = { group = "com.google.android.flexbox", name = "flexbox", version.ref = "flexbox" }
+arkbuilder-arkfilepicker = { group = "dev.arkbuilders", name = "arkfilepicker", version.ref = "arkFilepicker" }
+arkbuilder-arklib = { group = "dev.arkbuilders", name = "arklib", version.ref = "arkLib" }


Suggested change

arkbuilder-arklib = { group = "dev.arkbuilders", name = "arklib", version.ref = "arkLib" }

arkbuilders-arklib = { group = "dev.arkbuilders", name = "arklib", version.ref = "arkLib" }

shubertm · 2024-11-04T08:57:34Z

gradle/libs.versions.toml

+fastadapter = { group = "com.mikepenz", name = "fastadapter", version.ref = "fastadapter" }
+fastadapter-extensions-binding = { group = "com.mikepenz", name = "fastadapter-extensions-binding", version.ref = "fastadapter" }
+fastadapter-extensions-diff = { group = "com.mikepenz", name = "fastadapter-extensions-diff", version.ref = "fastadapter" }
+arklib = { group = "dev.arkbuilders", name = "arklib", version.ref = "arkLib" }


This is redundant, should be removed

shubertm · 2024-11-04T08:58:59Z

gradle/libs.versions.toml

+arklib = { group = "dev.arkbuilders", name = "arklib", version.ref = "arkLib" }
+orbit-mvi-viewmodel = { group = "org.orbit-mvi", name = "orbit-viewmodel", version.ref = "orbitMvi" }
+orbit-mvi-compose = { group = "org.orbit-mvi", name = "orbit-compose", version.ref = "orbitMvi" }
+viewbinding-property-delegate = { group = "com.github.kirich1409", name = "viewbindingpropertydelegate-noreflection", version.ref = "viewbindingPropertyDelegate" }


Suggested change

viewbinding-property-delegate = { group = "com.github.kirich1409", name = "viewbindingpropertydelegate-noreflection", version.ref = "viewbindingPropertyDelegate" }

viewbinding-property-delegate-noreflection = { group = "com.github.kirich1409", name = "viewbindingpropertydelegate-noreflection", version.ref = "viewbindingPropertyDelegate" }

tuancoltech · 2024-11-10T10:23:24Z

@shubertm This PR's branch is managed in rebase-based strategy.
Please don't push merge commit to it.
I'll be hard-resetting it now.

shubertm · 2024-11-10T12:30:37Z

@shubertm This PR's branch is managed in rebase-based strategy. Please don't push merge commit to it. I'll be hard-resetting it now.

So, would you please fix all issues I requested. Not all are fixed.

tuancoltech · 2024-11-11T05:48:47Z

@shubertm This PR's branch is managed in rebase-based strategy. Please don't push merge commit to it. I'll be hard-resetting it now.

So, would you please fix all issues I requested. Not all are fixed.

@shubertm You mean the changes you requested above?
I think all of them were fixed.
Could you do a git pull --rebase and check again?

shubertm · 2024-11-11T08:17:39Z

@shubertm This PR's branch is managed in rebase-based strategy. Please don't push merge commit to it. I'll be hard-resetting it now.

So, would you please fix all issues I requested. Not all are fixed.

@shubertm You mean the changes you requested above? I think all of them were fixed. Could you do a git pull --rebase and check again?

Yes, the redundant dependency arklib is still there

tuancoltech · 2024-11-11T15:15:03Z

@shubertm This PR's branch is managed in rebase-based strategy. Please don't push merge commit to it. I'll be hard-resetting it now.

So, would you please fix all issues I requested. Not all are fixed.

@shubertm You mean the changes you requested above? I think all of them were fixed. Could you do a git pull --rebase and check again?

Yes, the redundant dependency arklib is still there

@shubertm arklib is being used in app/build.gradle line 93.

shubertm · 2024-11-12T02:42:55Z

Yes, but in libs.versions.toml it is defined twice, line 39 and 64

….com/0/1207819682524134/1208308884950165

tuancoltech · 2024-11-12T05:34:55Z

Yes, but in libs.versions.toml it is defined twice, line 39 and 64

@shubertm That's a good catch!
Removed it now.

shubertm

All good now 🚀

tuancoltech self-assigned this Oct 28, 2024

tuancoltech temporarily deployed to Development October 28, 2024 16:00 — with GitHub Actions Inactive

tuancoltech requested review from shubertm and hieuwu October 28, 2024 16:01

shubertm requested changes Nov 4, 2024

View reviewed changes

tuancoltech force-pushed the enhance/migrate_to_version_catalog branch from 4d49920 to 24b1b08 Compare November 7, 2024 15:34

tuancoltech temporarily deployed to Development November 7, 2024 15:34 — with GitHub Actions Inactive

tuancoltech temporarily deployed to Development November 7, 2024 15:41 — with GitHub Actions Inactive

tuancoltech force-pushed the enhance/migrate_to_version_catalog branch from 24b1b08 to 2efdc79 Compare November 8, 2024 01:26

tuancoltech temporarily deployed to Development November 8, 2024 01:26 — with GitHub Actions Inactive

hieuwu approved these changes Nov 8, 2024

View reviewed changes

tuancoltech temporarily deployed to Development November 8, 2024 01:32 — with GitHub Actions Inactive

tuancoltech force-pushed the enhance/migrate_to_version_catalog branch from 2efdc79 to 4122a0c Compare November 8, 2024 05:41

tuancoltech temporarily deployed to Development November 8, 2024 05:41 — with GitHub Actions Inactive

tuancoltech requested a review from shubertm November 8, 2024 05:42

tuancoltech temporarily deployed to Development November 8, 2024 05:47 — with GitHub Actions Inactive

shubertm temporarily deployed to Development November 8, 2024 12:05 — with GitHub Actions Inactive

shubertm temporarily deployed to Development November 8, 2024 12:09 — with GitHub Actions Inactive

tuancoltech force-pushed the enhance/migrate_to_version_catalog branch from ffcb98a to 4122a0c Compare November 10, 2024 10:28

tuancoltech temporarily deployed to Development November 10, 2024 10:28 — with GitHub Actions Inactive

tuancoltech temporarily deployed to Development November 10, 2024 10:31 — with GitHub Actions Inactive

tuancoltech force-pushed the enhance/migrate_to_version_catalog branch from 4122a0c to 12a782b Compare November 10, 2024 10:45

tuancoltech temporarily deployed to Development November 10, 2024 10:45 — with GitHub Actions Inactive

tuancoltech temporarily deployed to Development November 10, 2024 10:49 — with GitHub Actions Inactive

Migrate hardcoded dependencies to version catalogs: https://app.asana…

510a0e3

….com/0/1207819682524134/1208308884950165

tuancoltech force-pushed the enhance/migrate_to_version_catalog branch from 12a782b to 510a0e3 Compare November 12, 2024 05:34

tuancoltech temporarily deployed to Development November 12, 2024 05:34 — with GitHub Actions Inactive

tuancoltech temporarily deployed to Development November 12, 2024 05:40 — with GitHub Actions Inactive

shubertm approved these changes Nov 12, 2024

View reviewed changes

hieuwu approved these changes Nov 12, 2024

View reviewed changes

shubertm added the QA_passed label Nov 12, 2024

tuancoltech merged commit 16286ba into main Nov 13, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate hardcoded dependencies to version catalog #82

Migrate hardcoded dependencies to version catalog #82

tuancoltech commented Oct 28, 2024

shubertm Nov 4, 2024

shubertm Nov 4, 2024

shubertm Nov 4, 2024

shubertm Nov 4, 2024

shubertm Nov 4, 2024

shubertm Nov 4, 2024

shubertm Nov 4, 2024

tuancoltech commented Nov 10, 2024

shubertm commented Nov 10, 2024 •

edited by tuancoltech

Loading

tuancoltech commented Nov 11, 2024

shubertm commented Nov 11, 2024

tuancoltech commented Nov 11, 2024

shubertm commented Nov 12, 2024 •

edited

Loading

tuancoltech commented Nov 12, 2024 •

edited

Loading

shubertm left a comment


		implementation 'com.github.kirich1409:viewbindingpropertydelegate-noreflection:1.5.9'
		implementation(libraries.viewbinding.property.delegate)

	implementation(libraries.arkbuilder.arkfilepicker)
	implementation(libraries.arkbuilders.arkfilepicker)

	implementation(libraries.arkbuilder.arklib)
	implementation(libraries.arkbuilders.arklib)

	arkbuilder-arkfilepicker = { group = "dev.arkbuilders", name = "arkfilepicker", version.ref = "arkFilepicker" }
	arkbuilders-arkfilepicker = { group = "dev.arkbuilders", name = "arkfilepicker", version.ref = "arkFilepicker" }

	arkbuilder-arklib = { group = "dev.arkbuilders", name = "arklib", version.ref = "arkLib" }
	arkbuilders-arklib = { group = "dev.arkbuilders", name = "arklib", version.ref = "arkLib" }

	viewbinding-property-delegate = { group = "com.github.kirich1409", name = "viewbindingpropertydelegate-noreflection", version.ref = "viewbindingPropertyDelegate" }
	viewbinding-property-delegate-noreflection = { group = "com.github.kirich1409", name = "viewbindingpropertydelegate-noreflection", version.ref = "viewbindingPropertyDelegate" }

Migrate hardcoded dependencies to version catalog #82

Migrate hardcoded dependencies to version catalog #82

Conversation

tuancoltech commented Oct 28, 2024

shubertm Nov 4, 2024

Choose a reason for hiding this comment

shubertm Nov 4, 2024

Choose a reason for hiding this comment

shubertm Nov 4, 2024

Choose a reason for hiding this comment

shubertm Nov 4, 2024

Choose a reason for hiding this comment

shubertm Nov 4, 2024

Choose a reason for hiding this comment

shubertm Nov 4, 2024

Choose a reason for hiding this comment

shubertm Nov 4, 2024

Choose a reason for hiding this comment

tuancoltech commented Nov 10, 2024

shubertm commented Nov 10, 2024 • edited by tuancoltech Loading

tuancoltech commented Nov 11, 2024

shubertm commented Nov 11, 2024

tuancoltech commented Nov 11, 2024

shubertm commented Nov 12, 2024 • edited Loading

tuancoltech commented Nov 12, 2024 • edited Loading

shubertm left a comment

Choose a reason for hiding this comment

shubertm commented Nov 10, 2024 •

edited by tuancoltech

Loading

shubertm commented Nov 12, 2024 •

edited

Loading

tuancoltech commented Nov 12, 2024 •

edited

Loading