Back gesture is recognized as drawing intent #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuancoltech
force-pushed
the
feat/implement_graphics_note_thumb
branch
from
db285fd to
fcc0550
Compare
tuancoltech
changed the base branch from
feat/implement_graphics_note_thumb
to
main
tuancoltech
force-pushed
the
enhance/back_gesture_conflict_draw_intent
branch
from
e44521d to
ab6e6ee
Compare
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
tuancoltech
changed the base branch from
main
to
feat/implement_graphics_note_thumb
tuancoltech
force-pushed
the
feat/implement_graphics_note_thumb
branch
from
fcc0550 to
ea4ca86
Compare
tuancoltech
changed the base branch from
feat/implement_graphics_note_thumb
to
main
tuancoltech
force-pushed
the
enhance/back_gesture_conflict_draw_intent
branch
from
ab6e6ee to
86ee76b
Compare
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
hieuwu
approved these changes
Nov 7, 2024
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When back gesture navigation is made from either left or right side of screen, it's mistakenly recognized as a drawing intent
in graphics note edit mode. This affects badly on UX.
https://app.asana.com/0/1207819682524134/1208536199909620
Solution
Do not draw if the gesture touch point is made within the edge (either left or right) side of screen.
Before
Screen.Recording.2024-10-18.at.21.42.15.mov
After
Screen.Recording.2024-10-18.at.21.47.18.mov