Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement graphics note's thumb #79

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Implement graphics note's thumb #79

merged 2 commits into from
Nov 7, 2024

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Oct 16, 2024 •
edited
Loading

Purpose:

Implement graphics note's thumb in Note list.

https://app.asana.com/0/1207819682524134/1207820310969749

Screenshot

Screenshot 2024-10-17 at 22 12 14

@tuancoltech tuancoltech self-assigned this Oct 16, 2024
@tuancoltech tuancoltech force-pushed the feat/implement_graphics_note_thumb branch from d2246b4 to db285fd Compare October 17, 2024 15:09
@tuancoltech tuancoltech changed the title WIP: Implement graphics note's thumb Implement graphics note's thumb Oct 17, 2024
@tuancoltech tuancoltech changed the base branch from enhance/validate_memo_files to main October 27, 2024 09:14
@tuancoltech tuancoltech force-pushed the feat/implement_graphics_note_thumb branch from db285fd to fcc0550 Compare October 27, 2024 09:19
shubertm
shubertm approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@shubertm shubertm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @tuancoltech 🚀
Code looks good, we just wait a little. I have made an inquiry to Imam about thumbnail background

@tuancoltech
Copy link
Collaborator Author

tuancoltech commented Nov 5, 2024 •
edited
Loading

Good work @tuancoltech 🚀 Code looks good, we just wait a little. I have made an inquiry to Imam about thumbnail background

@shubertm Thanks.
About the background color, if Imam decides to choose another color later on, I'll push another fix.
So, will be merging this PR for now if you think it's QA passed.?

@shubertm
Copy link
Member

shubertm commented Nov 5, 2024 •
edited
Loading

Good work @tuancoltech 🚀 Code looks good, we just wait a little. I have made an inquiry to Imam about thumbnail background

@shubertm Thanks. About the background color, if Imam decides to choose another color later on, I'll push another fix. So, will be merging this PR for now if you think it's QA passed.?

Yes, Imam is not available at the moment. Let's go on. Everything is ok. I will give it QA passed
Once you resolved the conflicts, feel free to merge

@tuancoltech tuancoltech force-pushed the feat/implement_graphics_note_thumb branch from fcc0550 to ea4ca86 Compare November 7, 2024 05:49
@tuancoltech
* Reformat code to align with KtLint rules
d6c1dff 
* Move LiveData observation with Fragment's viewLifecycleOwner to onViewCreated instead of onCreate
@tuancoltech tuancoltech merged commit 1dc6f4b into main Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubertm shubertm shubertm approved these changes

@hieuwu hieuwu hieuwu approved these changes

Assignees

@tuancoltech tuancoltech

Labels
feature QA_passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuancoltech @shubertm @hieuwu