Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app becomes unusable if user closes folder selection dialog #21

Closed
kirillt opened this issue Oct 21, 2023 · 1 comment
Closed

The app becomes unusable if user closes folder selection dialog #21

kirillt opened this issue Oct 21, 2023 · 1 comment
Assignees
@shubertm
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kirillt
Copy link
Member

kirillt commented Oct 21, 2023

  1. Install the app.
  2. Allow disk permissions.
  3. The app asks to select a folder for storing notes.
  4. Close the filepicker.
  5. Not possible to open it again. Not possible to create notes.
@kirillt kirillt added the bug Something isn't working label Oct 21, 2023
@kirillt kirillt added the good first issue Good for newcomers label Nov 18, 2023
@shubertm shubertm mentioned this issue Dec 5, 2023
Merged
@shubertm shubertm self-assigned this Dec 7, 2023
shubertm added a commit that referenced this issue Jan 11, 2024
@shubertm @hieuwu
@kirillt @tuancoltech @dependabot
#21: The app becomes unusable if user closes folder selection dialog (#…
b4d3d2b 
…32)

* Close app when no root folder is selected

* Minor refactors

* Create dependabot.yml (#31)

* Proper workflow location for Dependabot

* * SVG parsing
* SVG generating
* Fix gradle build and deprecated APIs
* Move local texts to string resource file
* Add extended fab
* Generalize file listing function
* Fix extra line feed in text content

Co-authored-by: Tuan Nguyen <[email protected]>

* Signing with a new keystore using GitHub Actions, bump JDK version

* Bump com.google.code.gson:gson from 2.8.9 to 2.10.1 (#33)

Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.8.9 to 2.10.1.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/main/CHANGELOG.md)
- [Commits](google/gson@gson-parent-2.8.9...gson-parent-2.10.1)

---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Close dialog on touch outside

* Disable closing dialog on touch outside

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: Kirill Taran <[email protected]>
Co-authored-by: Tuan Nguyen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@shubertm
Copy link
Member

Solved in #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubertm shubertm

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirillt @shubertm