Support Babel 6

[drewtunes]

React Native 0.16.0-rc uses Babel 6 so this would be nice. I'm not sure how much work that is to do.

[alvaromb]

Hi @cava23!!

Let me know if this PR #9 works for you and I'll merge it and make a release.

[alvaromb]

I think it's the best solution right now (take a look at this issue reduxjs/redux#1033), but keep in mind that the component is written un ES6 style so you should configure your own .babelrc in order to make it working.

[drewtunes]

Thanks for the PR. Unfortunately, I’m still having trouble. react-native-button pulls in it’s own version of react-native since I guess 0.16.0-rc doesn’t satisfy the dependency. I’m wondering if that’s an npm bug. I’m just going back to 0.15.0 for now. Uhhggg.

On Dec 2, 2015, at 12:50 AM, Álvaro Medina Ballester [email protected] wrote:

I think it's the best solution right now (take a look at this issue reduxjs/redux#1033 reduxjs/redux#1033), but keep in mind that the component is written un ES6 style so you should configure your own .babelrc in order to make it working.

—
Reply to this email directly or view it on GitHub #8 (comment).

[drewtunes]

Changing the last line of Button.js to:
module.exports = Button;
got it working on 0.16.0-rc.

On Dec 2, 2015, at 10:09 AM, Andrew Crowell [email protected] wrote:

Thanks for the PR. Unfortunately, I’m still having trouble. react-native-button pulls in it’s own version of react-native since I guess 0.16.0-rc doesn’t satisfy the dependency. I’m wondering if that’s an npm bug. I’m just going back to 0.15.0 for now. Uhhggg.

On Dec 2, 2015, at 12:50 AM, Álvaro Medina Ballester <[email protected] mailto:[email protected]> wrote:

I think it's the best solution right now (take a look at this issue reduxjs/redux#1033 reduxjs/redux#1033), but keep in mind that the component is written un ES6 style so you should configure your own .babelrc in order to make it working.

—
Reply to this email directly or view it on GitHub #8 (comment).

[alvaromb]

That's strange. I'm going to change the ES6 style and make a release. Once it's done, let me know if it works for you.

[alvaromb]

@cava23 keep in mind that the PR hasn't been merged yet, so if you want to try it you should install from it's own branch.

[alvaromb]

Just pushed https://github.com/APSL/react-native-button/releases/tag/v2.3.0. Let me know if it works for you!

[drewtunes]

That worked! Thanks.

On Dec 3, 2015, at 2:15 AM, Álvaro Medina Ballester [email protected] wrote:

Closed #8 #8.

—
Reply to this email directly or view it on GitHub #8 (comment).

[drewtunes]

btw, this commit facebook/react-native@dff8f53 facebook/react-native@dff8f53 fixes the issue with ES6 module export.

On Dec 3, 2015, at 6:23 PM, Andrew Crowell [email protected] wrote:

That worked! Thanks.

On Dec 3, 2015, at 2:15 AM, Álvaro Medina Ballester <[email protected] mailto:[email protected]> wrote:

Closed #8 #8.

—
Reply to this email directly or view it on GitHub #8 (comment).