Integrate apsim classic DCaPST #7713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el (taken from Classic).
…LNRatio from a calculated value (equalling 1.8) to 2.5 as recommended by Alex.
…as previously broken by new DCAPS code changes.
…types of Crop & Cultivars to be specified. Add sample config for this to the HE3 experiment.
…r via a string rather than multiple GetChild calls. Add Replacements to model to set the Cultivar settings for both the M35-1 & CSH13R Cultivars.
…ch has been superseded by the SorghumDCaPST model.
…t model Cultivar overrides can be tested.
…to IntegrateApsimClassicDCaPST
… and add extra region.
…dicated DCaPST directory.
…ding DCaPST to the model.
…phs and add Annotations/Memos to the corresponding sites that are missing simulations from the Classic DCaPST wheat validation. Remove DCaPST from model.
…the replacements for DCaPST based of off the DCaPST inputs spreadsheet.
…the DCaPSTParameters based on the crop type selected. Hide all of the DCaPSTParameters from the UI, apart from the CropName. Add an onchange event. Move TemperatureResponseValues into its own file.
… interface so that it can be mocked when testing. Change invalid namespaces (Mixture of DCaPST.Parameters, DCaPST and DCAPST).
…Validation defaults.
…n sub directory. Add DCaPSTModelNGTests.
…rator test classes.
…rator tests. Add Classic Default Generators so that they can be used to compare them.
…zation issue. Add DCaPST to the wheat validation model.
…mments on class name).
…rator (ICropParameterGenerator) so that this can be injected for testing purposes.
…er to DCaPST models. Add stub for replacements.
…defaults, as per spreadsheet. Start adding Daily Comparisons (New Vs Old) to Wheat model using exported data from Apsim Classic.
…ns (New Vs Old) using exported data from Apsim Classic.
… exactly as is from classic scripts (within the Classic software).
…anges the date format for the combined_<Site>.csv. Remove some of the values from the NewVsOld 9 panel graph.
…t fields from NewVsOld graphs.
…or everything apart from CSH13R as this is the only "Tall" Cultivar according to the Classic implementation.
…m/joesaddigh/ApsimX into IntegrateApsimClassicDCaPST_Wheat
…d tidy up as agreed.
…ut line from Clock.
… >= rather than > laiTrigger to match the Classic implementation. Refactor to adopt VS suggestions and add a safety check.
…Check with Jason).
…m/joesaddigh/ApsimX into IntegrateApsimClassicDCaPST_Wheat # Conflicts: # Models/DCaPST/DCaPSTModelNG.cs
…-1 simulations (Change from HE7CultivarM35-1r to HE7CultivarM35-1 and HE8CultivarM35-1r to HE8CultivarM35-1)
…uts and generate combined Results.
…son graphs (DCaPSTVsNoRootAdj and OldFixedVsNoDCaPST).
…y comparison graphs.
…to IntegrateApsimClassicDCaPST_Wheat
… BiomassWt in graphing.
…to IntegrateApsimClassicDCaPST_Wheat
|
This PR is now redundant and will be replaced with a new DCaPST PR in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #7705