Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorghum/documentation #7321

Merged
merged 22 commits into from
Jun 16, 2022
Merged

Conversation

jbrider
Copy link
Contributor

@jbrider jbrider commented Jun 5, 2022

working on #572

@jbrider
Copy link
Contributor Author

jbrider commented Jun 5, 2022

retest this please jenkins

@jbrider
Copy link
Contributor Author

jbrider commented Jun 5, 2022

@hol353 This looks to be failing soon after it starts running the simulations in the validation folder.
I can't tell which simulation it was running when it failed though.

@hol353
Copy link
Contributor

hol353 commented Jun 5, 2022

I'm not sure what you're seeing but I see lots of errors like this:

ERROR in file: ./Prototypes/C4Maize/C4Maize.apsimx
Simulation name: Angelo98FertN0
Models.Core.SimulationException
 ---> System.Exception: Cannot find a match for link nPhenoStressFunction in model .Angelo98FertN0.paddock.C4Maize.Leaf
   at Models.Core.Links.ResolveInternal(Object obj, ScopingRules scope, Boolean throwOnFail) in /tmp/ApsimX/Models/Core/Links.cs:line 191
   at Models.Core.Links.Resolve(IModel rootNode, Boolean allLinks, Boolean recurse, Boolean throwOnFail) in /tmp/ApsimX/Models/Core/Links.cs:line 46
   at Models.Core.Simulation.Prepare() in /tmp/ApsimX/Models/Core/Simulation.cs:line 272
   --- End of inner exception stack trace ---
   at Models.Core.Simulation.Prepare() in /tmp/ApsimX/Models/Core/Simulation.cs:line 276
   at APSIM.Shared.JobRunning.JobRunner.RunActualJob(IRunnable job, IJobManager jobManager) in /tmp/ApsimX/APSIM.Shared/JobRunning/JobRunner.cs:line 212

@jbrider
Copy link
Contributor Author

jbrider commented Jun 5, 2022

My bad - apparently I wasn't looking at the complete log.

@hol353
Copy link
Contributor

hol353 commented Jun 8, 2022

@jbrider Are you ready to have this merged?

@jbrider
Copy link
Contributor Author

jbrider commented Jun 8, 2022 via email

@hol353
Copy link
Contributor

hol353 commented Jun 8, 2022

I'm not working on anything related. I'll wait until next week to merge. Let me know when ready.

@jbrider
Copy link
Contributor Author

jbrider commented Jun 15, 2022

@hol353 when (if) this goes green, can you merge it - the input I have been waiting on has been further delayed so I would rather get this merged now and come back to it.

@hol353 hol353 merged commit bc007b3 into APSIMInitiative:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants