-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorghum/documentation #7321
Sorghum/documentation #7321
Conversation
Update Phenology Thermal Time Stress Calculation to reflect changes made to Nitrogen stress period.
…constants within ReproductiveOrgan
retest this please jenkins |
@hol353 This looks to be failing soon after it starts running the simulations in the validation folder. |
I'm not sure what you're seeing but I see lots of errors like this:
|
My bad - apparently I wasn't looking at the complete log. |
@jbrider Are you ready to have this merged? |
Not quite - pretty close though. Should be right to merge on Monday morning.
It can be merged if you're going to work on documentation though.
…On Thu, Jun 9, 2022 at 7:48 AM Dean Holzworth ***@***.***> wrote:
@jbrider <https://github.com/jbrider> Are you ready to have this merged?
—
Reply to this email directly, view it on GitHub
<#7321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE3G7DDN6EYHXWAKPAOSDLVOEIKHANCNFSM5X4OXWJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'm not working on anything related. I'll wait until next week to merge. Let me know when ready. |
@hol353 when (if) this goes green, can you merge it - the input I have been waiting on has been further delayed so I would rather get this merged now and come back to it. |
working on #572