reorganizing code to current standards #6698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please jenkins |
|
Yep - you'll need to edit your initial comment and add "working on #x" (with an issue number). One of the jobs on my list is to get ApsimBot to post a comment to this effect when it spots a PR missing this bit. |
|
Oops. It has been a while... |
|
retest this please jenkins |
|
retest this please jenkins |
1 similar comment
|
retest this please jenkins |
|
@hol353 this is right to merge - and will make the next PR much easier to follow. |
|
@hol430 It can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on #572
@hol353 Finally getting back to sorghum - I have reorganised the order according to the coding standards spec, which has created a lot of changes. It should go green, if so, can you merge it.
There are more changes to come but until this one is merged it will be hard to see what those changes are (trying to make it a bit easier).
I have mainly moved code around, changed the readonly getters to use lambdas and changed some public to private.
I still have to fix some capitalisations.
There are a few private variables in the wrong place - they will be extracted out in the next stage.
I will close the old pull request once I have made sure I have captured all the changes from it.