Get AgPasture into release

[sno036]

Past due that AgPasture was officially in release. Here starting the process. This is what Mariana is doing.

[sno036]

@hol353 can you add "mpandreucci" to the project please? (is that 'whitelisting'?)

[hol353]

@sno036 @mpandreucci Is this now ready for review by the Reference Panel?

[mpandreucci]

I don't know if @sno036 will want to add some managers to it. If she doesn't want to add anything else to it, then I think it's ready.
The only thing is that the graph still has some black points, instead of all of them being coloured. I'm not sure if it's something that needs to be fixed by you @hol353

[hol353]

Which graph is it?

[mpandreucci]

The predicted x observed from the Radcliffe validation test

[sarahcleary]

@APSIMInitiative/reference-panel - to be discussed in Friday's RP meeting. In the meantime, any suggestions for reviewers?

[sno036]

Matt Harrison suggested as a reviewer

[sarahcleary]

RP agreed to see if Matt Harrison was available and willing to review (AI RP May Meeting). @sarahcleary to contact Matt Harrison

[sarahcleary]

@sno036 - can you please provide the instructions for the reviewer - where can he find the validation example and documentation?

[sarahcleary]

Sent request to Matt Harrison to see if he is available to review model

[sarahcleary]

AgPasture review ApsimX Matthew Harrison.docx
AgPastureTest3929MH1.pdf
AgPasture3929MH2.pdf
Review by Matthew Harrison.

[sarahcleary]

@APSIMInitiative/reference-panel - Review docs from Matthew Harrison above. Please read prior to July RP meeting

[sarahcleary]

@sno036 - please note comment in RP Meeting

[sno036]

@sarahcleary - apologies but I don't think that I'm going to get to respond to the review comments before the RP meeting.

[sno036]

Remaining to do:

• remove the Sward from the validation version of AgPasture. simulations (@sno036 before release)
• add a Manager to access the expert-level parameters (@hol353 but can be after release)
• delete Sward from the AgPasture code base (@hol353 but can be after release)
• ?? anything else?

[sno036]

@sarahcleary, this is now ready for release. All the comments from Matt have been acted on, the example simulation is tidy for new users.

[sarahcleary]

@APSIMInitiative/reference-panel - please note @sno036's comment above

[hol353]

@sarahcleary Following last weeks RP meeting, can I put AgPasture into release?

[sarahcleary]

@hol353 - yes.