Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle id dereference #141

Closed
wants to merge 1 commit into from
Closed

handle id dereference #141

wants to merge 1 commit into from

Conversation

mathieudutour
Copy link
Contributor

fix #136

@coveralls
Copy link

coveralls commented Nov 5, 2019

Pull Request Test Coverage Report for Build 367

  • 15 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 92.572%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/pointer.js 12 14 85.71%
Totals Coverage Status
Change from base Build 364: -0.07%
Covered Lines: 7495
Relevant Lines: 7920

💛 - Coveralls

@transitive-bullshit
Copy link

This is a really solid PR -- great work @mathieudutour. Would also love to see this merged.

@jrnail23
Copy link

Are there plans to merge this? I'm impacted by this issue and would also love to see it merged.

@philsturgeon
Copy link
Member

philsturgeon commented Jun 26, 2020

$id/$ref is a pretty wild topic so we'd need a lot more input from the JSON Schema experts. #145 already has a pretty solid roadmap for 2019-09 support, so maybe we should focus our efforts on that instead?

@unlimitechcloud
Copy link

Hi, im needing this too, any ETA?

@philsturgeon
Copy link
Member

@unlimitechcloud could you try this PR out and see if it works for your use cases?

@philsturgeon
Copy link
Member

Conflicts and original branch has gone. This is being handled in https://github.com/APIDevTools/json-schema-reader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal $id reference not derefernced
6 participants