Adding keycloak migration for permission matrix #2352
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Thanks @auslin-aot , I will change it to use script instead as there seems no direct way to do this with import. |
Please review the changes |
|
|
||
| groups_to_role_mappings = { | ||
| "formsflow/formsflow-admin": [ | ||
| "manage_users", |
There was a problem hiding this comment.
formsflow-admin group is not given as the default group in the previous release so while getting get_group_id() it fails
| # Get client and group IDs | ||
| client_id = get_client_id(token, "forms-flow-web") | ||
| client_roles = get_client_roles(token, client_id) | ||
| update_client_roles(token, client_id, roles_to_update) |
There was a problem hiding this comment.
client_roles here will have old roles (formsflow-designer,..) and will not satisfy the if condition client_role['name'] == role_to_lookup on line 161. So roles will be empty. Can you please check.
There was a problem hiding this comment.
This code basically, matches the client roles which needs to be added to the group and then assign it to the group, so for older roles it doesn't need to get into the if loop as those role assignment exists on the group. Do you see issues with this approach ?
There was a problem hiding this comment.
Yes. Here client_roles will have only old roles(on update_client_roles() - new roles added to the client). So when I executed the script, roles were added to the client, but the new roles were not added to the group(since new roles are not there in client_roles, so not get in the if loop). Executing the script again new roles are added to the group.
|
Script output when the client doesnt have permission |
|
Script output once the permission is added |
|
|
Merging thihs PR for now. Any multitenancy related or pending edga cases can be sorted out in a new PR @sumesh-aot cc @auslin-aot |
Issue Tracking
JIRA: https://aottech.atlassian.net/browse/FWF-3720
Issue Type: BUG/ FEATURE
Changes
Screenshots (if applicable)
Checklist