CMakeLists.txt work around zlib/CMakeLists.txt bug #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joedrago
approved these changes
May 25, 2023
vigneshvg
approved these changes
May 25, 2023
Put an include_directories() call with the source directory of ext/zlib before add_subdirectory(ext/zlib) to work around a zlib/CMakeLists.txt bug fixed by madler/zlib#818. The parent project's include directories at the time of an add_subdirectory() call are used by the child project, so the order of include_directories() and add_subdirectory() is important.
wantehchang
force-pushed
the
work-around-zlib-CMakeLists-txt-bug
branch
from
130113b
to
634267e
Compare
jzern
approved these changes
May 25, 2023
|
Thanks for the review. I forced-pushed a new version of the commit, which has the same idea as the version that Joe and Vignesh reviewed. I made the workaround as small as possible. I also explained why the two include_directories() calls are needed by add_subdirectory(ext/libpng). |
vigneshvg
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt work around zlib/CMakeLists.txt bug
Put an include_directories() call with the source directory of ext/zlib
before add_subdirectory(ext/zlib) to work around a zlib/CMakeLists.txt
bug fixed by madler/zlib#818.
The parent project's include directories at the time of an
add_subdirectory() call are used by the child project, so the order of
include_directories() and add_subdirectory() is important.